Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): attempt mitigation of flaky integration test against containerized AGW #14188

Conversation

Neudrino
Copy link
Contributor

Summary

  • Allow for some more attempt to start containers properly.
  • In case of final failing state, give a more detailed output of containers including container ID, to enable further mitigation steps.

Test Plan

  • CI

@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines. label Oct 17, 2022
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: agw Access gateway-related issue label Oct 17, 2022
@Neudrino Neudrino marked this pull request as ready for review October 17, 2022 09:37
@Neudrino Neudrino requested a review from a team as a code owner October 17, 2022 09:37
@Neudrino Neudrino requested review from uri200, crasu, sebathomas, voisey and ajahl and removed request for uri200 October 17, 2022 09:37
@github-actions
Copy link
Contributor

github-actions bot commented Oct 17, 2022

feg-workflow

    2 files  203 suites   39s ⏱️
374 tests 374 ✔️ 0 💤 0
388 runs  388 ✔️ 0 💤 0

Results for commit 85d4d37.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 17, 2022

dp-workflow

14 tests   14 ✔️  2m 36s ⏱️
  1 suites    0 💤
  1 files      0

Results for commit 85d4d37.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 17, 2022

agw-workflow

615 tests   611 ✔️  4m 43s ⏱️
    2 suites      4 💤
    2 files        0

Results for commit 85d4d37.

♻️ This comment has been updated with latest results.

@Neudrino Neudrino enabled auto-merge (squash) October 17, 2022 10:49
@Neudrino Neudrino force-pushed the ci/improve-containerized-agw-integration-test-stability branch from 054e3fa to 9a457e7 Compare October 17, 2022 14:14
…inerized AGW

Signed-off-by: Fritz Lehnert <13189449+Neudrino@users.noreply.github.com>
@Neudrino Neudrino force-pushed the ci/improve-containerized-agw-integration-test-stability branch from 9a457e7 to 85d4d37 Compare October 17, 2022 15:03
@magma magma deleted a comment from github-actions bot Oct 17, 2022
@Neudrino Neudrino merged commit e96707f into magma:master Oct 18, 2022
@Neudrino Neudrino deleted the ci/improve-containerized-agw-integration-test-stability branch October 18, 2022 06:58
lucasgonze pushed a commit to lucasgonze/magma that referenced this pull request Feb 29, 2024
…inerized AGW (magma#14188)

Signed-off-by: Fritz Lehnert <13189449+Neudrino@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: agw Access gateway-related issue size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants