Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(agw): valid printing and cleanup for fabfile AGW #14199

Conversation

Neudrino
Copy link
Contributor

Summary

  • Normal Python print functions are not visible from within fabfile. Used the fab-specific commands instead.
  • Simplified one useless method.

Test Plan

  • CI

Signed-off-by: Fritz Lehnert <13189449+Neudrino@users.noreply.github.com>
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines. label Oct 17, 2022
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: agw Access gateway-related issue label Oct 17, 2022
@Neudrino Neudrino marked this pull request as ready for review October 17, 2022 11:09
@Neudrino Neudrino requested a review from a team as a code owner October 17, 2022 11:09
@Neudrino Neudrino enabled auto-merge (squash) October 17, 2022 11:10
@github-actions
Copy link
Contributor

feg-workflow

    2 files  203 suites   40s ⏱️
374 tests 374 ✔️ 0 💤 0
388 runs  388 ✔️ 0 💤 0

Results for commit 203d6a1.

@github-actions
Copy link
Contributor

dp-workflow

14 tests   14 ✔️  2m 24s ⏱️
  1 suites    0 💤
  1 files      0

Results for commit 203d6a1.

@github-actions
Copy link
Contributor

agw-workflow

615 tests   611 ✔️  3m 47s ⏱️
    2 suites      4 💤
    2 files        0

Results for commit 203d6a1.

@Neudrino Neudrino merged commit 8ba6977 into magma:master Oct 17, 2022
@Neudrino Neudrino deleted the ci/fix-printing-and-consolidate-fabfile-for-agw branch October 17, 2022 12:09
@Neudrino Neudrino linked an issue Oct 17, 2022 that may be closed by this pull request
lucasgonze pushed a commit to lucasgonze/magma that referenced this pull request Feb 29, 2024
Signed-off-by: Fritz Lehnert <13189449+Neudrino@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: agw Access gateway-related issue size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI support for dockerized agw enable stable s1ap tests
2 participants