feat(ci): Add federated integ test for PCRF #14200

orion-belt · 2022-10-17T12:24:29Z

Signed-off-by: Rohan Kharade rohan.kharade@openairinterface.org
Co-authered by: Nitin Rajput nitinrajput706021@gmail.com

Summary

This PR adds Federated Integ Test to validate PCRF Gx interface. Here we are reusing existing lte-integ-tests in fedrated mode.

Following tests are added in this PR which leverages PCRF Gx interface over federated gateway -

test_attach_dettach
test_attach_dettach_multi_ue
test_duplicate_attach.py
test_attach_detach_after_ue_context_release.py
test_attach_detach_dedicated_bearer_deactivation_invalid_imsi.py
test_attach_detach_dedicated_multi_ue.py
test_attach_detach_looped.py
test_attach_detach_secondary_pdn_invalid_apn.py
test_attach_detach_security_algo_eea0_eia0.py
test_attach_detach_security_algo_eea1_eia1.py
test_attach_detach_security_algo_eea2_eia2.py
test_attach_detach_with_mme_restart.py
test_attach_ipv4v6_pdn_type.py
test_attach_missing_imsi.py
test_attach_mme_restart_detach_multi_ue.py
test_attach_service_without_mac.py
test_no_attach_complete.py
test_no_auth_resp_with_mme_restart_reattach.py
test_no_auth_response_with_mme_restart.py
test_standalone_pdn_conn_req.py
test_standalone_pdn_conn_req_with_apn_correction.py

pcrf_test_log.txt

Test Plan

Track issue here
We are reusing some of existing and relevant tests from lte-integ-tests. The sheet attached describes the priority and relevancy of tests. Please feel free to update sheet accordingly.

Additional Information

This change is backwards-breaking

github-actions · 2022-10-17T12:24:43Z

Thanks for opening a PR! 💯

A couple initial guidelines

All commits must be signed off. This is enforced by DCO check.
All PR titles must follow the semantic commits format. This is enforced by Semantic PR.

Howto

Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
Checks. All required CI checks must pass before merge.
Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

Contributing Conventions for norms around contributed code

If this is your first Magma PR, also consider reading

Developer Onboarding for onboarding as a new Magma developer
Development Workflow for guidance on your first pull request
CI Checks for points of contact for failing or flaky CI checks
GitHub-to-Slack mappings for Magma maintainers for guidance on how to contact maintainers on Slack

github-actions · 2022-10-17T12:25:39Z

Oops! Looks like you failed the DCO check. Be sure to sign all your commits.

Howto

♻️ Updated: ✅ The check is passing the DCO check after the last commit.

github-actions · 2022-10-17T12:26:31Z

Oops! Looks like you failed the Python Format Check.

Howto

Instructions on running the formatter and linter locally are provided in the format AGW doc
Guide to the different CI checks and resolution guidelines

♻️ Updated: ✅ The check is passing the Python Format Check after the last commit.

github-actions · 2022-10-17T12:33:57Z

feg-workflow

    2 files 203 suites 41s ⏱️
374 tests 374 ✔️ 0 💤 0 ❌
388 runs 388 ✔️ 0 💤 0 ❌

Results for commit 73d47dc.

♻️ This comment has been updated with latest results.

github-actions · 2022-10-17T13:07:05Z

dp-workflow

14 tests 14 ✔️ 3m 8s ⏱️
  1 suites   0 💤
  1 files   0 ❌

Results for commit 73d47dc.

♻️ This comment has been updated with latest results.

github-actions · 2022-10-17T14:11:43Z

agw-workflow

615 tests 611 ✔️ 4m 35s ⏱️
    2 suites     4 💤
    2 files     0 ❌

Results for commit 73d47dc.

♻️ This comment has been updated with latest results.

nstng · 2022-10-17T15:45:44Z

lte/gateway/python/integ_tests/common/gx_gy_client.py

@@ -0,0 +1,69 @@
+"""


I do not see this file used anywhere - what am I missing?

OK, seems to have been added to s1ap_wrapper in the meantime.

nstng · 2022-10-18T07:42:24Z

lte/gateway/python/integ_tests/common/gx_gy_client.py

+        self._mock_ocs_stub.CreateAccount(SubscriberID(id=imsi))
+
+
+class OCSGrpc(OCSGrpcClient):


I do not see this used anywhere.

It is for gy (OCS) tests that will be added soon

Maybe best introduce it together with the tests then to not mix two topics in one PR and remove it for now from this one.

nstng · 2022-10-18T07:49:50Z

lte/gateway/python/integ_tests/s1aptests/s1ap_wrapper.py

@@ -229,7 +236,7 @@ def configIpBlock(self):
        print("************************* Waiting for IP changes to propagate")
        self._mobility_util.wait_for_changes()

-    def configUEDevice(self, num_ues, req_data=None, static_ips=None):
+    def configUEDevice(self, num_ues, req_data=None, static_ips=None, mock_pcrf=False):


What is the difference between self.mock_pcrf and the argument mock_pcrf here? Is the argument actually needed?

mpfirrmann · 2022-11-07T10:01:57Z

lte/gateway/python/integ_tests/s1aptests/test_attach_detach.py

@@ -20,7 +21,8 @@
 class TestAttachDetach(unittest.TestCase):

    def setUp(self):
-        self._s1ap_wrapper = s1ap_wrapper.TestWrapper()
+        self.mock_pcrf = {True if (os.environ.get("FEDERATED_MODE") == "True") else False}


The curly braces must be removed for self.mock_pcrf to become boolean. Otherwise, it will be a set and the if self.mock_pcrf check always becomes true. Please do this for all tests.

And I think this can be simplified to

self.mock_pcrf = os.environ.get("FEDERATED_MODE") == "True"

github-actions · 2022-11-07T17:09:12Z

✔️ The Semantic PR check ended with status success. See instructions on formatting your commit and pull request titles.

Signed-off-by: Nitin Rajput<nitinrajput706021@gmail.com> Signed-off-by: kharade <rohan.kharade@openairinterface.org>

Signed-off-by: kharade <rohan.kharade@openairinterface.org>

orion-belt requested a review from a team October 17, 2022 12:24

orion-belt requested a review from a team as a code owner October 17, 2022 12:24

orion-belt requested review from pruthvihebbani and pshelar October 17, 2022 12:24

pull-request-size bot added the size/L Denotes a Pull Request that changes 100-499 lines. label Oct 17, 2022

github-actions bot added the component: agw Access gateway-related issue label Oct 17, 2022

orion-belt mentioned this pull request Oct 17, 2022

Adding federated integration tests #14185

Open

4 tasks

orion-belt requested review from a team and jheidbrink October 17, 2022 14:32

nstng reviewed Oct 17, 2022

View reviewed changes

nstng reviewed Oct 18, 2022

View reviewed changes

mpfirrmann requested changes Nov 7, 2022

View reviewed changes

orion-belt changed the title ~~feat(ci): Add federated integ test for PCRF~~ Draft:feat(ci): Add federated integ test for PCRF Nov 7, 2022

orion-belt changed the title ~~Draft:feat(ci): Add federated integ test for PCRF~~ feat(ci): Add federated integ test for PCRF Nov 7, 2022

orion-belt marked this pull request as draft November 7, 2022 17:23

orion-belt added 4 commits November 14, 2022 14:49

Added ocs and pcrf services for federated mode

ba8d1ec

Signed-off-by: Nitin Rajput<nitinrajput706021@gmail.com> Signed-off-by: kharade <rohan.kharade@openairinterface.org>

Init the gRPC stub to connect to mock PCRF

b7214d0

Signed-off-by: kharade <rohan.kharade@openairinterface.org>

Enable mock pcrf for relavent tests

b973adf

Signed-off-by: kharade <rohan.kharade@openairinterface.org>

Remove OCS grpc stub and code cleanup

c1a7b24

Signed-off-by: kharade <rohan.kharade@openairinterface.org>

orion-belt closed this by deleting the head repository Jan 15, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(ci): Add federated integ test for PCRF #14200

feat(ci): Add federated integ test for PCRF #14200

orion-belt commented Oct 17, 2022 •

edited

github-actions bot commented Oct 17, 2022

github-actions bot commented Oct 17, 2022 •

edited

github-actions bot commented Oct 17, 2022 •

edited

github-actions bot commented Oct 17, 2022 •

edited

github-actions bot commented Oct 17, 2022 •

edited

github-actions bot commented Oct 17, 2022 •

edited

nstng Oct 17, 2022

nstng Oct 18, 2022

nstng Oct 18, 2022

orion-belt Oct 18, 2022

mpfirrmann Nov 7, 2022

nstng Oct 18, 2022

mpfirrmann Nov 7, 2022

sebathomas Nov 7, 2022

github-actions bot commented Nov 7, 2022 •

edited

		self._mock_ocs_stub.CreateAccount(SubscriberID(id=imsi))


		class OCSGrpc(OCSGrpcClient):

feat(ci): Add federated integ test for PCRF #14200

feat(ci): Add federated integ test for PCRF #14200

Conversation

orion-belt commented Oct 17, 2022 • edited

Summary

Following tests are added in this PR which leverages PCRF Gx interface over federated gateway -

Test Plan

Additional Information

github-actions bot commented Oct 17, 2022

Howto

More info

github-actions bot commented Oct 17, 2022 • edited

Howto

github-actions bot commented Oct 17, 2022 • edited

Howto

github-actions bot commented Oct 17, 2022 • edited

feg-workflow

github-actions bot commented Oct 17, 2022 • edited

dp-workflow

github-actions bot commented Oct 17, 2022 • edited

agw-workflow

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Nov 7, 2022 • edited

orion-belt commented Oct 17, 2022 •

edited

github-actions bot commented Oct 17, 2022 •

edited

github-actions bot commented Oct 17, 2022 •

edited

github-actions bot commented Oct 17, 2022 •

edited

github-actions bot commented Oct 17, 2022 •

edited

github-actions bot commented Oct 17, 2022 •

edited

github-actions bot commented Nov 7, 2022 •

edited