Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ci): Run most integration tests against containerized AGW on CI #14214

Merged
merged 1 commit into from
Oct 20, 2022
Merged

feat(ci): Run most integration tests against containerized AGW on CI #14214

merged 1 commit into from
Oct 20, 2022

Conversation

Neudrino
Copy link
Contributor

@Neudrino Neudrino commented Oct 18, 2022 •
edited

Summary

Test Plan

@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines. label Oct 18, 2022
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added component: agw Access gateway-related issue component: ci All updates on CI (Jenkins/CircleCi/Github Action) labels Oct 18, 2022
@Neudrino Neudrino mentioned this pull request Oct 18, 2022
Merged
@github-actions
Copy link
Contributor

github-actions bot commented Oct 18, 2022 •
edited

feg-workflow

    2 files  203 suites   39s ⏱️
374 tests 374 ✔️ 0 💤 0 ❌
388 runs  388 ✔️ 0 💤 0 ❌

Results for commit ef4ec4f.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 18, 2022 •
edited

dp-workflow

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 4163011.

♻️ This comment has been updated with latest results.

@Neudrino Neudrino removed the request for review from mpfirrmann October 18, 2022 14:43
@github-actions
Copy link
Contributor

github-actions bot commented Oct 18, 2022 •
edited

agw-workflow

615 tests   611 ✔️  4m 31s ⏱️
    2 suites      4 💤
    2 files        0 ❌

Results for commit ef4ec4f.

♻️ This comment has been updated with latest results.

@Neudrino Neudrino force-pushed the ci/s1ap-tests-against-containerised-agw-most-test branch from 71e3158 to ef4ec4f Compare October 19, 2022 09:39
@pull-request-size pull-request-size bot added size/S Denotes a PR that changes 10-29 lines. and removed size/M Denotes a PR that changes 30-99 lines. labels Oct 19, 2022
@Neudrino
feat(ci): parallelize integration tests for containerised AGW
4163011 
Signed-off-by: Fritz Lehnert <13189449+Neudrino@users.noreply.github.com>
@Neudrino Neudrino force-pushed the ci/s1ap-tests-against-containerised-agw-most-test branch from ef4ec4f to 4163011 Compare October 19, 2022 15:29
@github-actions github-actions bot removed the component: agw Access gateway-related issue label Oct 19, 2022
@Neudrino Neudrino marked this pull request as ready for review October 19, 2022 15:31
@Neudrino Neudrino requested a review from a team as a code owner October 19, 2022 15:31
@Neudrino Neudrino mentioned this pull request Oct 19, 2022
Closed
@LKreutzer
Copy link
Contributor

I restarted the failing build-all jobs. There seems to have been some connection issues - at least for one of the jobs.

LKreutzer
LKreutzer approved these changes Oct 20, 2022
View reviewed changes
Copy link
Contributor

@LKreutzer LKreutzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm - see comment about publishing the results.

How did you get the workflow to run with these changes on magma/magma?

.github/workflows/lte-integ-test-containerized.yml
run: |
cd lte/gateway
fab get_test_summaries:dst_path="test-results,sudo_tests=False"
fab get_test_summaries:dst_path="test-results",sudo_tests=False,dev_vm_name="magma_deb"
- name: Upload test results
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we also publish the test results after this step?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but lets do it in a separate follow up PR, ok?

@Neudrino
Copy link
Contributor Author

How did you get the workflow to run with these changes on magma/magma?

Have a look at #14115 last commit (ef4ec4f). Just modify the run condition a bit. 😉

@Neudrino Neudrino merged commit 05a2fb2 into magma:master Oct 20, 2022
@Neudrino Neudrino deleted the ci/s1ap-tests-against-containerised-agw-most-test branch October 20, 2022 12:24
lucasgonze pushed a commit to lucasgonze/magma that referenced this pull request Feb 29, 2024
@Neudrino @lucasgonze
feat(ci): parallelize integration tests for containerised AGW (magma#…
112905f 
…14214)

Signed-off-by: Fritz Lehnert <13189449+Neudrino@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LKreutzer LKreutzer LKreutzer approved these changes

@jheidbrink jheidbrink Awaiting requested review from jheidbrink

Assignees
No one assigned
Labels
component: ci All updates on CI (Jenkins/CircleCi/Github Action) size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Neudrino @LKreutzer