Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci): Remove sudo tests from make LTE integ test workflow #14233

Merged
merged 1 commit into from
Oct 31, 2022
Merged

chore(ci): Remove sudo tests from make LTE integ test workflow #14233

merged 1 commit into from
Oct 31, 2022

Conversation

voisey
Copy link
Contributor

@voisey voisey commented Oct 20, 2022 •
edited

Summary

Closes #14161.

⚠️ We should wait until #14160 has been merged before merging this.

Test Plan

  • Run workflow on fork. Workflow fails due to flaky tests but runs through without running the sudo tests.

@voisey
chore(ci): Remove sudo tests from make LTE integ test workflow
72f32d9 
Signed-off-by: Cameron Voisey <cameron.voisey@tngtech.com>
@voisey voisey added the DONOTLAND Please don't merge this label Oct 20, 2022
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines. label Oct 20, 2022
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: agw Access gateway-related issue label Oct 20, 2022
@github-actions
Copy link
Contributor

feg-workflow

    2 files  203 suites   40s ⏱️
374 tests 374 ✔️ 0 💤 0 ❌
388 runs  388 ✔️ 0 💤 0 ❌

Results for commit 72f32d9.

@github-actions
Copy link
Contributor

dp-workflow

14 tests   14 ✔️  2m 30s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit 72f32d9.

@github-actions
Copy link
Contributor

agw-workflow

615 tests   611 ✔️  3m 58s ⏱️
    2 suites      4 💤
    2 files        0 ❌

Results for commit 72f32d9.

@voisey voisey marked this pull request as ready for review October 24, 2022 06:54
@voisey voisey requested a review from a team as a code owner October 24, 2022 06:54
@voisey voisey requested a review from ardzoht October 24, 2022 06:54
sebathomas
sebathomas approved these changes Oct 25, 2022
View reviewed changes
lte/gateway/fabfile.py Show resolved Hide resolved
@voisey voisey removed the DONOTLAND Please don't merge this label Oct 31, 2022
@voisey
Copy link
Contributor Author

voisey commented Oct 31, 2022

The Bazel sudo test workflow is now in the CI dashboard so I will merge this.

@voisey voisey merged commit 41b18da into magma:master Oct 31, 2022
@Neudrino Neudrino added the LTE-Integration-Test Issues relating to LTE Integration Tests label Nov 16, 2022
@Neudrino Neudrino mentioned this pull request Nov 16, 2022
Closed
6 tasks
lucasgonze pushed a commit to lucasgonze/magma that referenced this pull request Feb 29, 2024
@voisey @lucasgonze
chore(ci): Remove sudo tests from make LTE integ test workflow (magma…
7d05e22 
…#14233)

Signed-off-by: Cameron Voisey <cameron.voisey@tngtech.com>

Signed-off-by: Cameron Voisey <cameron.voisey@tngtech.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LKreutzer LKreutzer LKreutzer left review comments

@Neudrino Neudrino Neudrino approved these changes

@sebathomas sebathomas sebathomas approved these changes

@ardzoht ardzoht Awaiting requested review from ardzoht ardzoht was automatically assigned from magma/approvers-agw

Assignees
No one assigned
Labels
component: agw Access gateway-related issue LTE-Integration-Test Issues relating to LTE Integration Tests size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove sudo tests from LTE make dev-build workflow
4 participants
@voisey @Neudrino @sebathomas @LKreutzer