feat(nms): Show NGC AMF config for gateways #14243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a PR! 💯
Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
Neudrino
reviewed
Oct 24, 2022
Comment on lines
+784
to
+798
| const nameCell = within(ngcConfig).getByTestId('Name'); | ||
| within(nameCell).getByText('amf.example.org'); | ||
| const pointerCell = within(ngcConfig).getByTestId('Pointer'); | ||
| within(pointerCell).getByText('1F'); | ||
| const regionCell = within(ngcConfig).getByTestId('Region ID'); | ||
| within(regionCell).getByText('C1'); | ||
| const setCell = within(ngcConfig).getByTestId('Set ID'); | ||
| within(setCell).getByText('2A1'); | ||
| const serviceTypeCell = within(ngcConfig).getByTestId( | ||
| 'Default Slice Service Type', | ||
| ); | ||
| within(serviceTypeCell).getByText('2'); | ||
| const descriptorCell = within(ngcConfig).getByTestId( | ||
| 'Default Slice Descriptor', | ||
| ); | ||
| within(descriptorCell).getByText('AFAF'); |
There was a problem hiding this comment.
Is the category of those items really identical to the testID?
I mean for the single fields testID is never set, however you getByTestId here, where I would have expected a getByText or getByName or the like.
There was a problem hiding this comment.
It's a feature of the data grid that sets the category automatically as test ID for the whole cell (including title and value as children). If I used getByText, I'd only get the title and not the value that I want to check.
sebathomas
force-pushed
the
nms-show-ngc-config
branch
from
02143db
to
ebd98b1
Compare
Neudrino
approved these changes
Oct 24, 2022
Adds a new section to the Gateway Config that shows the NGC AMF configuration. The data is already available in the frontend as part of the gateway data. Also moves the EPC config to the left column to make room for the new config on the right column. Signed-off-by: Sebastian Thomas <sebastian.thomas@tngtech.com>
sebathomas
force-pushed
the
nms-show-ngc-config
branch
from
ebd98b1
to
6bfb295
Compare
4 tasks
lucasgonze
pushed a commit
to lucasgonze/magma
that referenced
this pull request
Feb 29, 2024
Adds a new section to the Gateway Config that shows the NGC AMF configuration. The data is already available in the frontend as part of the gateway data. Also moves the EPC config to the left column to make room for the new config on the right column. Signed-off-by: Sebastian Thomas <sebastian.thomas@tngtech.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new section to the Gateway Config that shows the NGC AMF configuration. The data is already available in the frontend as part of the gateway data.
Also moves the EPC config to the left column to make room for the new config on the right column.
A new dialog to edit the config will be added in a follow-up PR.
Config with example data:
Empty config:
Test Plan
Additional Information