Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): remove the always failing amis workflow #14247

Merged
merged 1 commit into from
Oct 25, 2022

Conversation

Neudrino
Copy link
Contributor

Summary

  • Remove always failing amis-workflow.
  • Magma does not currently provide AMIs anymore anyway. They were all removed from AWS store as well.
  • With containerized AGW the future necessity of AMIs is questionable.

@pull-request-size pull-request-size bot added the size/L Denotes a Pull Request that changes 100-499 lines. label Oct 24, 2022
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@Neudrino Neudrino marked this pull request as ready for review October 24, 2022 14:36
@Neudrino Neudrino requested a review from a team as a code owner October 24, 2022 14:36
@github-actions github-actions bot added the component: ci All updates on CI (Jenkins/CircleCi/Github Action) label Oct 24, 2022
@Neudrino Neudrino enabled auto-merge (squash) October 24, 2022 14:36
@github-actions
Copy link
Contributor

github-actions bot commented Oct 24, 2022

dp-workflow

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit 02aac0a.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@LKreutzer LKreutzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Signed-off-by: Fritz Lehnert <13189449+Neudrino@users.noreply.github.com>
@Neudrino Neudrino merged commit 0dce719 into magma:master Oct 25, 2022
@Neudrino Neudrino deleted the ci/remove-amis-workflow branch October 25, 2022 10:57
@LKreutzer LKreutzer mentioned this pull request Nov 7, 2022
1 task
lucasgonze pushed a commit to lucasgonze/magma that referenced this pull request Feb 29, 2024
Signed-off-by: Fritz Lehnert <13189449+Neudrino@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: ci All updates on CI (Jenkins/CircleCi/Github Action) size/L Denotes a Pull Request that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants