chore(ci): remove debug-only hmarr/debug-action
#14275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a PR! 💯
Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
github-actions
bot
added
the
component: ci
Neudrino
changed the title
hmarr/debug-action version to remove deprecation wa…hmarr/debug-action version to remove deprecation warning
LKreutzer
approved these changes
Oct 26, 2022
Neudrino
requested changes
Oct 26, 2022
| @@ -26,7 +26,7 @@ jobs: | |||
| WORKFLOW_NAME: "${{ github.event.workflow.name }}" | |||
| WORKFLOW_STATUS: "${{ github.event.workflow_run.conclusion }}" | |||
| steps: | |||
| - uses: hmarr/debug-action@1201a20fc9d278ddddd5f0f46922d06513892491 # pin@v2 | |||
| - uses: hmarr/debug-action@a701ed95a46e6f2fb0df25e1a558c16356fae35a # pin@v2.1.0 | |||
There was a problem hiding this comment.
This seems to be an action only used for debugging. It should thus probably not be in production code. If this is really the only occurrence, could we just remove it entirely instead please?
There was a problem hiding this comment.
This is the only occurrence in the Magma repo and has been in this file since its original commit. The action only prints the environment variables and therefore may be removed in production code.
Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com>
mpfirrmann
force-pushed
the
pr/bump_debug_action
branch
from
1a20f7d
to
87f9b9f
Compare
mpfirrmann
changed the title
hmarr/debug-action version to remove deprecation warninghmarr/debug-action
Neudrino
approved these changes
Oct 26, 2022
lucasgonze
pushed a commit
to lucasgonze/magma
that referenced
this pull request
Feb 29, 2024
Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com> Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
hmarr/debug-actionis a debug-only action and not needed in production code. Removed.Test Plan
Additional Information