Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci): bump geekyeggo/delete-artifact version to remove deprecation warning #14276

Merged
merged 1 commit into from
Oct 26, 2022
Merged

chore(ci): bump geekyeggo/delete-artifact version to remove deprecation warning #14276

merged 1 commit into from
Oct 26, 2022

Conversation

mpfirrmann
Copy link
Contributor

@mpfirrmann mpfirrmann commented Oct 26, 2022 •
edited by Neudrino

Summary

GitHub deprecated Node 12 in favor of Node 16. This PR bumps the version of the third party library geekyeggo/delete-artifact from v1 to the latest version v2.0.0 with an adapted Node version.

Test Plan

  • Full text search on repository for 'geekyeggo/delete-artifact'
  • CI

Additional Information

  • This change is backwards-breaking

@mpfirrmann
chore(ci): bump geekyeggo/delete-artifact version to remove depreca…
5990e0f 
…tion warning

Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com>
@mpfirrmann mpfirrmann requested a review from a team as a code owner October 26, 2022 12:23
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines. label Oct 26, 2022
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: ci All updates on CI (Jenkins/CircleCi/Github Action) label Oct 26, 2022
@Neudrino Neudrino changed the title chore(ci): bump geekyeggo/delete-artifact version to remove depreca… chore(ci): bump geekyeggo/delete-artifact version to remove deprecation warning Oct 26, 2022
@github-actions
Copy link
Contributor

dp-workflow

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 5990e0f.

@mpfirrmann mpfirrmann enabled auto-merge (squash) October 26, 2022 12:58
@mpfirrmann mpfirrmann merged commit 49aef49 into magma:master Oct 26, 2022
@mpfirrmann mpfirrmann deleted the pr/bump_delete_artifact branch October 26, 2022 13:08
lucasgonze pushed a commit to lucasgonze/magma that referenced this pull request Feb 29, 2024
@mpfirrmann @lucasgonze
chore(ci): bump geekyeggo/delete-artifact version to remove depreca…
9f55b39 
…tion warning (magma#14276)

Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com>

Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Neudrino Neudrino Neudrino approved these changes

Assignees
No one assigned
Labels
component: ci All updates on CI (Jenkins/CircleCi/Github Action) size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mpfirrmann @Neudrino