Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): ignore exit status from single test sets #14278

Merged
merged 2 commits into from
Oct 28, 2022
Merged

fix(ci): ignore exit status from single test sets #14278

merged 2 commits into from
Oct 28, 2022

Conversation

Neudrino
Copy link
Contributor

@Neudrino Neudrino commented Oct 26, 2022 •
edited

Summary

Allow for multiple test sets to be run, even though, there is an failure in one of them.

Test Plan

Additional Information

  • Fixing failing integration tests is out of scope for this PR.

@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines. label Oct 26, 2022
@Neudrino Neudrino requested a review from nstng October 26, 2022 12:46
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: agw Access gateway-related issue label Oct 26, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 26, 2022 •
edited

dp-workflow

14 tests   14 ✔️  2m 11s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit 4691dca.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 26, 2022 •
edited

agw-workflow

615 tests   611 ✔️  4m 50s ⏱️
    2 suites      4 💤
    2 files        0 ❌

Results for commit 4691dca.

♻️ This comment has been updated with latest results.

@Neudrino Neudrino force-pushed the ci/ignore-errors-on-integration-tests branch from bfc127b to 1e206d1 Compare October 26, 2022 13:51
@pull-request-size pull-request-size bot added size/S Denotes a PR that changes 10-29 lines. and removed size/XS Denotes a PR that changes 0-9 lines. labels Oct 26, 2022
@Neudrino Neudrino marked this pull request as ready for review October 26, 2022 13:53
@Neudrino Neudrino requested a review from a team October 26, 2022 13:53
@Neudrino Neudrino requested a review from a team as a code owner October 26, 2022 13:53
@github-actions
Copy link
Contributor

github-actions bot commented Oct 26, 2022 •
edited

feg-workflow

    2 files  203 suites   39s ⏱️
374 tests 374 ✔️ 0 💤 0 ❌
388 runs  388 ✔️ 0 💤 0 ❌

Results for commit 4691dca.

♻️ This comment has been updated with latest results.

@Neudrino Neudrino requested a review from a team as a code owner October 26, 2022 15:42
@github-actions github-actions bot added the component: ci All updates on CI (Jenkins/CircleCi/Github Action) label Oct 26, 2022
@Neudrino Neudrino force-pushed the ci/ignore-errors-on-integration-tests branch from 86c99d5 to 50aa4e1 Compare October 26, 2022 15:45
@Neudrino Neudrino force-pushed the ci/ignore-errors-on-integration-tests branch from 50aa4e1 to 8024625 Compare October 27, 2022 08:58
@Neudrino Neudrino force-pushed the ci/ignore-errors-on-integration-tests branch from 8024625 to ca72aaf Compare October 27, 2022 11:22
nstng
nstng approved these changes Oct 27, 2022
View reviewed changes
Copy link
Contributor

@nstng nstng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checked test runs: all tests are executed, even if a test in a category fails.
will set "do not land" for now because of test commit that needs to be removed.

@nstng nstng added the DONOTLAND Please don't merge this label Oct 27, 2022
@Neudrino
fix(ci): ignore exit status from single test sets
a300451 
Signed-off-by: Fritz Lehnert <13189449+Neudrino@users.noreply.github.com>
@Neudrino
fix(ci): move the comment the correct place
4691dca 
Signed-off-by: Fritz Lehnert <13189449+Neudrino@users.noreply.github.com>
@Neudrino Neudrino force-pushed the ci/ignore-errors-on-integration-tests branch from ca72aaf to 4691dca Compare October 28, 2022 08:11
@github-actions github-actions bot removed the component: ci All updates on CI (Jenkins/CircleCi/Github Action) label Oct 28, 2022
@Neudrino
Copy link
Contributor Author

will set "do not land" for now because of test commit that needs to be removed.

Removed the test commit and rebased on master.

@Neudrino Neudrino enabled auto-merge (squash) October 28, 2022 08:12
@Neudrino Neudrino removed the DONOTLAND Please don't merge this label Oct 28, 2022
@Neudrino Neudrino merged commit dc9cd7b into magma:master Oct 28, 2022
@Neudrino Neudrino deleted the ci/ignore-errors-on-integration-tests branch October 28, 2022 09:11
lucasgonze pushed a commit to lucasgonze/magma that referenced this pull request Feb 29, 2024
@Neudrino @lucasgonze
fix(ci): ignore exit status from single test sets (magma#14278)
50dc8dc 
* fix(ci): ignore exit status from single test sets
* fix(ci): move the comment the correct place

Signed-off-by: Fritz Lehnert <13189449+Neudrino@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpfirrmann mpfirrmann mpfirrmann approved these changes

@voisey voisey voisey approved these changes

@nstng nstng nstng approved these changes

Assignees
No one assigned
Labels
component: agw Access gateway-related issue size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Neudrino @mpfirrmann @voisey @nstng