Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Set parameter for both build and test #14311

Merged
merged 1 commit into from
Oct 28, 2022
Merged

chore: Set parameter for both build and test #14311

merged 1 commit into from
Oct 28, 2022

Conversation

jheidbrink
Copy link
Contributor

@jheidbrink jheidbrink commented Oct 28, 2022 •
edited

Summary

Change one parameter from test to build.

The settings for the test verb inherits settings from the build verb. By applying the same settings to build and test we increase the cache usage.

@jheidbrink
chore: Set parameter for both build and test
6c1ac0e 
The test verb inherits settings for the build verb. Settings for the
build and test verb should largely be the same for better cache reuse.

Signed-off-by: Jan Heidbrink <jan.heidbrink@tngtech.com>
@jheidbrink jheidbrink added the bazel changes for the Bazelification effort label Oct 28, 2022
@jheidbrink jheidbrink requested review from a team and vktng October 28, 2022 06:35
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines. label Oct 28, 2022
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions
Copy link
Contributor

dp-workflow

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 6c1ac0e.

@jheidbrink jheidbrink enabled auto-merge (squash) October 28, 2022 06:37
@github-actions
Copy link
Contributor

agw-workflow

615 tests   611 ✔️  3m 51s ⏱️
    2 suites      4 💤
    2 files        0 ❌

Results for commit 6c1ac0e.

@jheidbrink jheidbrink merged commit 4e0cae5 into magma:master Oct 28, 2022
@jheidbrink jheidbrink mentioned this pull request Nov 1, 2022
Closed
lucasgonze pushed a commit to lucasgonze/magma that referenced this pull request Feb 29, 2024
@jheidbrink @lucasgonze
chore: Set parameter for both build and test (magma#14311)
7dceb1a 
The test verb inherits settings for the build verb. Settings for the
build and test verb should largely be the same for better cache reuse.

Signed-off-by: Jan Heidbrink <jan.heidbrink@tngtech.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LKreutzer LKreutzer LKreutzer approved these changes

@vktng vktng Awaiting requested review from vktng

Assignees
No one assigned
Labels
bazel changes for the Bazelification effort size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jheidbrink @LKreutzer