-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(agw): Modified code to fix the issue 14244 #14327
Conversation
Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
Thanks for opening a PR! 💯
Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code change looks good. Could you run the lte integ tests with this change from your repo to prove the error message is gone.
…4244 Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
6c10071
to
a2b4a48
Compare
Yes @crasu Locally verified that the protobuf error messages are not seen. But while I was self reviewing I got to know that similar changes are needed at some other places. Modified the code and again kept for executing "lte integ_tests". Let you know once that is completed |
@crasu, "lte integ_tests" completed successfully in local setup |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
Summary
Closes #14244
Modified code to read enb_name in character array format as expected by API, set_guage(). Since enb_name, read from proto files was in string format was resulting into serialization and de-serialization errors.
The PR provides fixes for the issue, #14244
Test Plan
Executed s1ap sanity test suite and unit test cases