Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(agw): Fix broken integration test #14331

Merged
merged 1 commit into from
Oct 31, 2022

Conversation

sebathomas
Copy link
Contributor

@sebathomas sebathomas commented Oct 31, 2022

Summary

Pytest fails calling the constructor. But moving the magma_utils initialization to setUp works.

Test Plan

Execute the test. (It is part of the non-sanity tests and does not run in the CI.)

Additional Information

  • This change is backwards-breaking

Pytest fails calling the constructor. But moving the magma_utils
initialization to setUp works.

Signed-off-by: Sebastian Thomas <sebastian.thomas@tngtech.com>
@sebathomas sebathomas requested review from a team and ulaskozat October 31, 2022 14:54
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines. label Oct 31, 2022
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: agw Access gateway-related issue label Oct 31, 2022
@sebathomas sebathomas enabled auto-merge (squash) October 31, 2022 15:46
@sebathomas sebathomas merged commit bfb1473 into magma:master Oct 31, 2022
lucasgonze pushed a commit to lucasgonze/magma that referenced this pull request Feb 29, 2024
Pytest fails calling the constructor. But moving the magma_utils
initialization to setUp works.

Signed-off-by: Sebastian Thomas <sebastian.thomas@tngtech.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: agw Access gateway-related issue size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants