Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(agw): Modifed code to port hash list of ue contexts to protobuf map #14342

Merged
merged 4 commits into from
Nov 7, 2022

Conversation

rsarwad
Copy link
Contributor

@rsarwad rsarwad commented Nov 2, 2022

Summary

fix(agw): Modifed code to port hash list of ue contexts to protobuf map

Test Plan

Executed s1ap sanity test suite and unit test cases.

Additional Information

This PR is duplicate of #13895 because of DCO check failure

Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
@rsarwad rsarwad requested review from a team and ulaskozat November 2, 2022 11:23
@pull-request-size pull-request-size bot added the size/L Denotes a Pull Request that changes 100-499 lines. label Nov 2, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 2, 2022

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: agw Access gateway-related issue label Nov 2, 2022
@pruthvihebbani
Copy link
Contributor

@rsarwad Can you please rebase to resolve insync checkin failure

…text_hash

Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
Copy link
Contributor

@pruthvihebbani pruthvihebbani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ue_context_p = new spgw_ue_context_t();
LIST_INIT(&ue_context_p->sgw_s11_teid_list);
hashtable_ts_insert(sgw_state->imsi_ue_context_htbl,
(const hash_key_t)imsi64, (void*)ue_context_p);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[cpplint] reported by reviewdog 🐶
Using C-style cast. Use reinterpret_cast<void*>(...) instead [readability/casting] [4]

Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
…text_hash

Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
@rsarwad rsarwad merged commit 33af906 into magma:master Nov 7, 2022
jheidbrink pushed a commit to jheidbrink/magma that referenced this pull request Nov 8, 2022
lucasgonze pushed a commit to lucasgonze/magma that referenced this pull request Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: agw Access gateway-related issue size/L Denotes a Pull Request that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants