fix(agw): Modified code in sgw_s8 task to port ue context hash table to protobuf map #14406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…edure_id to protobuf map Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
After rebase revisit this branch Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
…d_hl Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
…d_hl Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
…d_hl Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
pull-request-size
bot
added
the
size/L
|
Thanks for opening a PR! 💯
Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
|
✔️ The Semantic PR check ended with status success. See instructions on formatting your commit and pull request titles. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| } | ||
| free_cpp_wrapper((void**)ptr); |
There was a problem hiding this comment.
[cpplint] reported by reviewdog 🐶
Using C-style cast. Use reinterpret_cast<void**>(...) instead [readability/casting] [4]
There was a problem hiding this comment.
Please finx cpplint errors
| return; | ||
| } | ||
| state_cache_p->imsi_ue_context_map.map = | ||
| new google::protobuf::Map<unsigned long int, struct spgw_ue_context_s*>(); |
There was a problem hiding this comment.
[cpplint] reported by reviewdog 🐶
Use int16/int64/etc, rather than the C type long [runtime/int] [4]
pruthvihebbani
requested changes
Nov 10, 2022
| } | ||
| free_cpp_wrapper((void**)ptr); |
There was a problem hiding this comment.
Please finx cpplint errors
| return; | ||
| } | ||
| state_cache_p->imsi_ue_context_map.map = | ||
| new google::protobuf::Map<unsigned long int, struct spgw_ue_context_s*>(); |
rsarwad
changed the title
…ask and sgw_s8 task Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
rsarwad
force-pushed
the
11190_s8_port_ue_ctx_hl
branch
from
d62ab0b
to
a49ee75
Compare
ajahl
reviewed
Nov 14, 2022
…ctx_hl Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
rsarwad
force-pushed
the
11190_s8_port_ue_ctx_hl
branch
from
9c35a36
to
2b844f5
Compare
ajahl
approved these changes
Nov 23, 2022
Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
lucasgonze
pushed a commit
to lucasgonze/magma
that referenced
this pull request
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fix(agw): Modified code in sgw_s8 task to port ue context hash table to protobuf map
Removed dependency of spgw task and sgw_s8 task on hash table
Test Plan
Executed unit test cases and built with "make build_oai" and executed s1ap sanity test suite
We will not be able to verify inbound roaming feature in local setup.
Additional Information
Needs to be tested federated integ_tests once PCRF is integrated