fix(agw): Deleted temporary file emm_headers.hpp and moved functions out of extern #14489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pruthvi Hebbani <pruthvi.hebbani@radisys.com>
Signed-off-by: Pruthvi Hebbani <pruthvi.hebbani@radisys.com>
Signed-off-by: Pruthvi Hebbani <pruthvi.hebbani@radisys.com>
Signed-off-by: Pruthvi Hebbani <pruthvi.hebbani@radisys.com>
Signed-off-by: Pruthvi Hebbani <pruthvi.hebbani@radisys.com>
Signed-off-by: Pruthvi Hebbani <pruthvi.hebbani@radisys.com>
Signed-off-by: Pruthvi Hebbani <pruthvi.hebbani@radisys.com>
Signed-off-by: Pruthvi Hebbani <pruthvi.hebbani@radisys.com>
Signed-off-by: Pruthvi Hebbani <pruthvi.hebbani@radisys.com>
Signed-off-by: Pruthvi Hebbani <pruthvi.hebbani@radisys.com>
Signed-off-by: Pruthvi Hebbani <pruthvi.hebbani@radisys.com>
Signed-off-by: Pruthvi Hebbani <pruthvi.hebbani@radisys.com>
Signed-off-by: Pruthvi Hebbani <pruthvi.hebbani@radisys.com>
Signed-off-by: Pruthvi Hebbani <pruthvi.hebbani@radisys.com>
Signed-off-by: Pruthvi Hebbani <pruthvi.hebbani@radisys.com>
Signed-off-by: Pruthvi Hebbani <pruthvi.hebbani@radisys.com>
Signed-off-by: Pruthvi Hebbani <pruthvi.hebbani@radisys.com>
Signed-off-by: Pruthvi Hebbani <pruthvi.hebbani@radisys.com>
Signed-off-by: Pruthvi Hebbani <pruthvi.hebbani@radisys.com>
Signed-off-by: Pruthvi Hebbani <pruthvi.hebbani@radisys.com>
Signed-off-by: Pruthvi Hebbani <pruthvi.hebbani@radisys.com>
Signed-off-by: Pruthvi Hebbani <pruthvi.hebbani@radisys.com>
Signed-off-by: Pruthvi Hebbani <pruthvi.hebbani@radisys.com>
Signed-off-by: Pruthvi Hebbani <pruthvi.hebbani@radisys.com>
Signed-off-by: Pruthvi Hebbani <pruthvi.hebbani@radisys.com>
Signed-off-by: Pruthvi Hebbani <pruthvi.hebbani@radisys.com>
Signed-off-by: Pruthvi Hebbani <pruthvi.hebbani@radisys.com>
Signed-off-by: Pruthvi Hebbani <pruthvi.hebbani@radisys.com>
Signed-off-by: Pruthvi Hebbani <pruthvi.hebbani@radisys.com>
Signed-off-by: Pruthvi Hebbani <pruthvi.hebbani@radisys.com>
Signed-off-by: Pruthvi Hebbani <pruthvi.hebbani@radisys.com>
…ove_emm_headers_file
Signed-off-by: Pruthvi Hebbani <pruthvi.hebbani@radisys.com>
Signed-off-by: Pruthvi Hebbani <pruthvi.hebbani@radisys.com>
pull-request-size
bot
added
the
size/XL
|
Thanks for opening a PR! 💯
Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
pruthvihebbani
changed the title
ajahl
approved these changes
Nov 18, 2022
LKreutzer
approved these changes
Nov 22, 2022
|
@pruthvihebbani, can you fix the conflicts? |
rsarwad
reviewed
Nov 25, 2022
| @@ -55,7 +55,6 @@ extern "C" { | |||
| } | |||
| #endif | |||
| @@ -26,7 +26,6 @@ extern "C" { | |||
| } | |||
| #endif | |||
| #include "lte/gateway/c/core/oai/tasks/nas/emm/emm_data.hpp" | |||
| @@ -23,7 +23,6 @@ extern "C" { | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Remove dynamic_memory_check.h from extern C
| @@ -34,7 +36,6 @@ extern "C" { | |||
| #include "lte/gateway/c/core/oai/include/mme_config.hpp" | |||
| #include "lte/gateway/c/core/oai/include/s6a_messages_types.hpp" | |||
| #include "lte/gateway/c/core/oai/tasks/s6a/s6a_messages.hpp" | |||
| #include "lte/gateway/c/core/oai/tasks/s6a/s6a_fd_iface.hpp" | |||
| #include "orc8r/gateway/c/common/service303/MetricsHelpers.hpp" | |||
|
|
|||
| #include <iostream> | |||
| @@ -24,6 +24,7 @@ | |||
|
|
|||
| #pragma once | |||
|
|
|||
| #include "S1ap_S1AP-PDU.h" | |||
| #include "lte/gateway/c/core/common/common_defs.h" | |||
| #include "lte/gateway/c/core/oai/common/common_types.h" | |||
| #include "lte/gateway/c/core/oai/include/mme_app_messages_types.hpp" | |||
There was a problem hiding this comment.
Include bstrlib.h, s1ap_messages_types.h under extern C
| @@ -22,6 +22,8 @@ | |||
| \email: lionel.gauthier@eurecom.fr | |||
| */ | |||
|
|
|||
| #include "lte/gateway/c/core/oai/tasks/s1ap/s1ap_mme_nas_procedures.hpp" | |||
|
|
|||
| #include <stdio.h> | |||
| #include <stdint.h> | |||
| #include <stdlib.h> | |||
There was a problem hiding this comment.
Move bstrlib.h file under extern C.
Signed-off-by: Pruthvi Hebbani <pruthvi.hebbani@radisys.com>
lucasgonze
pushed a commit
to lucasgonze/magma
that referenced
this pull request
Feb 29, 2024
…out of extern (magma#14489) * Deleted temporary file emm_headers.hpp and moved functions out of extern Signed-off-by: Pruthvi Hebbani <pruthvi.hebbani@radisys.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(agw): Deleted temporary file emm_headers.hpp and moved functions out of extern
Summary
In order to resolve undefined references, function declarations that were causing undefined references were commented out in the original files and added to a temporary file emm_headers.hpp. Now that all the files in mme_app and nas are migrated to C++, emm_headers.hpp is not needed. In this PR emm_headers.hpp is deleted and the function declarations are uncommented.
Test Plan
Executed the following builds/tests: