-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(agw): Converted sms_orc8r task files to cpp #14494
fix(agw): Converted sms_orc8r task files to cpp #14494
Conversation
Signed-off-by: VinashakAnkitAman <ankit.aman@radisys.com>
Signed-off-by: VinashakAnkitAman <ankit.aman@radisys.com>
Thanks for opening a PR! 💯
Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
Signed-off-by: VinashakAnkitAman <ankit.aman@radisys.com>
Signed-off-by: VinashakAnkitAman <ankit.aman@radisys.com>
Signed-off-by: Ankit Kumar Aman <ankit.aman@radisys.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bazel changes lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* fix(agw): Converted sms_orc8r task files to cpp Signed-off-by: VinashakAnkitAman <ankit.aman@radisys.com> * Updated header ordering and externs Signed-off-by: VinashakAnkitAman <ankit.aman@radisys.com> Signed-off-by: VinashakAnkitAman <ankit.aman@radisys.com> Signed-off-by: Ankit Kumar Aman <ankit.aman@radisys.com>
Title
fix(agw): Converted sms_orc8r task files to cpp [Extension to Github Issue: #13096]
Summary
Migrated all the files related to sms_orc8r task in the folders
magma/lte/gateway/c/core/oai/tasks/sms_orc8r/
andmagma/lte/gateway/c/core/oai/include/
tocpp/hpp
and fixed all the compilation errors and warnings.Also followed the guidelines for order of headers from https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes
Test plan
Verified compilation with following:
make clean; bazel build --config=production //lte/gateway/c/core:agw_ofmake clean; bazel test //lte/gateway/c/core/oai/test/amf:amf_stateless_testmake clean; export FEATURES=mme_oai; make build_oaiThese compilations are no more valid on latest master after removal of target test_oai from Make file:
Verified with sanity and in CI
Signed-off-by: VinashakAnkitAman ankit.aman@radisys.com