Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(agw): Converted sms_orc8r task files to cpp #14494

Merged

Conversation

VinashakAnkitAman
Copy link
Member

@VinashakAnkitAman VinashakAnkitAman commented Nov 21, 2022

Title

fix(agw): Converted sms_orc8r task files to cpp [Extension to Github Issue: #13096]

Summary

Migrated all the files related to sms_orc8r task in the folders magma/lte/gateway/c/core/oai/tasks/sms_orc8r/ and magma/lte/gateway/c/core/oai/include/ to cpp/hpp and fixed all the compilation errors and warnings.

Also followed the guidelines for order of headers from https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes

Test plan

Verified compilation with following:

  • make clean; make build_oai;
  • make clean; bazel build //lte/gateway/c/core:agw_of
    make clean; bazel build --config=production //lte/gateway/c/core:agw_of
  • make clean; bazel test //lte/gateway/c/core/...
    make clean; bazel test //lte/gateway/c/core/oai/test/amf:amf_stateless_test
  • make clean; make FEATURES=mme_oai build_oai
    make clean; export FEATURES=mme_oai; make build_oai

These compilations are no more valid on latest master after removal of target test_oai from Make file:

make clean; make test_oai;
make clean; make test_oai BUILD_TYPE=Debug OAI_TESTS=test_amf_app

Verified with sanity and in CI

Signed-off-by: VinashakAnkitAman ankit.aman@radisys.com

Signed-off-by: VinashakAnkitAman <ankit.aman@radisys.com>
Signed-off-by: VinashakAnkitAman <ankit.aman@radisys.com>
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines. label Nov 21, 2022
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: agw Access gateway-related issue label Nov 21, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 21, 2022

FeG Lint & Test

    2 files  203 suites   40s ⏱️
374 tests 374 ✔️ 0 💤 0
388 runs  388 ✔️ 0 💤 0

Results for commit 819decf.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 21, 2022

DP Lint & Test

14 tests   14 ✔️  2m 30s ⏱️
  1 suites    0 💤
  1 files      0

Results for commit 819decf.

♻️ This comment has been updated with latest results.

Signed-off-by: VinashakAnkitAman <ankit.aman@radisys.com>
Signed-off-by: VinashakAnkitAman <ankit.aman@radisys.com>
@VinashakAnkitAman VinashakAnkitAman marked this pull request as ready for review November 21, 2022 14:12
@VinashakAnkitAman VinashakAnkitAman requested review from a team and nstng November 21, 2022 14:12
Signed-off-by: Ankit Kumar Aman <ankit.aman@radisys.com>
Copy link
Contributor

@nstng nstng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bazel changes lgtm

Copy link
Contributor

@pruthvihebbani pruthvihebbani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ajahl ajahl merged commit af7ec7e into magma:master Nov 25, 2022
lucasgonze pushed a commit to lucasgonze/magma that referenced this pull request Feb 29, 2024
* fix(agw): Converted sms_orc8r task files to cpp

Signed-off-by: VinashakAnkitAman <ankit.aman@radisys.com>

* Updated header ordering and externs

Signed-off-by: VinashakAnkitAman <ankit.aman@radisys.com>

Signed-off-by: VinashakAnkitAman <ankit.aman@radisys.com>
Signed-off-by: Ankit Kumar Aman <ankit.aman@radisys.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: agw Access gateway-related issue size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants