-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(agw): Migrate guti_ue_context_htbl in mme_app to protobuf map #14638
Open
VinashakAnkitAman
wants to merge
9
commits into
magma:master
Choose a base branch
from
VinashakAnkitAman:ankit_migrated_guti_ue_ctxt_htbl_in_mme_App_to_protobuf_map
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
fix(agw): Migrate guti_ue_context_htbl in mme_app to protobuf map #14638
VinashakAnkitAman
wants to merge
9
commits into
magma:master
from
VinashakAnkitAman:ankit_migrated_guti_ue_ctxt_htbl_in_mme_App_to_protobuf_map
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: VinashakAnkitAman <ankit.aman@radisys.com>
pull-request-size
bot
added
the
size/L
Denotes a Pull Request that changes 100-499 lines.
label
Dec 7, 2022
Thanks for opening a PR! 💯
Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
Signed-off-by: VinashakAnkitAman <ankit.aman@radisys.com>
Signed-off-by: VinashakAnkitAman <ankit.aman@radisys.com>
ajahl
approved these changes
Dec 8, 2022
rsarwad
reviewed
Dec 12, 2022
lte/gateway/c/core/oai/tasks/mme_app/mme_app_state_converter.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: VinashakAnkitAman <ankit.aman@radisys.com>
Signed-off-by: VinashakAnkitAman <ankit.aman@radisys.com>
Signed-off-by: VinashakAnkitAman <ankit.aman@radisys.com>
Signed-off-by: VinashakAnkitAman <ankit.aman@radisys.com>
rsarwad
reviewed
Dec 21, 2022
…ashtables Signed-off-by: VinashakAnkitAman <ankit.aman@radisys.com>
Signed-off-by: VinashakAnkitAman <ankit.aman@radisys.com>
pshelar
approved these changes
Jan 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@VinashakAnkitAman Can you resolve the conflicts to push this commit. Thanks. |
Lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component: agw
Access gateway-related issue
component: orc8r
Orchestrator-related issue
size/L
Denotes a Pull Request that changes 100-499 lines.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(agw): Migrate guti_ue_context_htbl in mme_app to protobuf map
Summary
Migrated guti_ue_context_htbl in mme_app to protobuf map
pb.go file generated using command:
./build.py -g
in the pathmagma/orc8r/cloud/docker
in magma-dev vmAlso added reference TODO comments for all pending hashlists:
g_e_dns_entries
,imei_htbl
andsac_to_tacs_map_htbl
Test Plan
Verified compilation with following:
make clean; bazel build --config=production //lte/gateway/c/core:agw_ofmake clean; bazel test //lte/gateway/c/core/oai/test/amf:amf_stateless_testmake clean; export FEATURES=mme_oai; make build_oaiThese compilations are no more valid on latest master after removal of target test_oai from Make file:
Verified with sanity and in CI
Signed-off-by: VinashakAnkitAman ankit.aman@radisys.com