Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(agw): Migrate guti_ue_context_htbl in mme_app to protobuf map #14638

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

VinashakAnkitAman
Copy link
Member

@VinashakAnkitAman VinashakAnkitAman commented Dec 7, 2022

fix(agw): Migrate guti_ue_context_htbl in mme_app to protobuf map

Summary

Migrated guti_ue_context_htbl in mme_app to protobuf map

pb.go file generated using command: ./build.py -g in the path magma/orc8r/cloud/docker in magma-dev vm

Also added reference TODO comments for all pending hashlists: g_e_dns_entries, imei_htbl and sac_to_tacs_map_htbl

Test Plan

Verified compilation with following:

  • make clean; make build_oai;
  • make clean; bazel build //lte/gateway/c/core:agw_of
    make clean; bazel build --config=production //lte/gateway/c/core:agw_of
  • make clean; bazel test //lte/gateway/c/core/...
    make clean; bazel test //lte/gateway/c/core/oai/test/amf:amf_stateless_test
  • make clean; make FEATURES=mme_oai build_oai
    make clean; export FEATURES=mme_oai; make build_oai

These compilations are no more valid on latest master after removal of target test_oai from Make file:

make clean; make test_oai;
make clean; make test_oai BUILD_TYPE=Debug OAI_TESTS=test_amf_app

Verified with sanity and in CI

Signed-off-by: VinashakAnkitAman ankit.aman@radisys.com

Signed-off-by: VinashakAnkitAman <ankit.aman@radisys.com>
@pull-request-size pull-request-size bot added the size/L Denotes a Pull Request that changes 100-499 lines. label Dec 7, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2022

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: agw Access gateway-related issue label Dec 7, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2022

FeG Lint & Test

    2 files  203 suites   40s ⏱️
374 tests 374 ✔️ 0 💤 0
388 runs  388 ✔️ 0 💤 0

Results for commit 36c47c7.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2022

DP Lint & Test

14 tests   14 ✔️  2m 18s ⏱️
  1 suites    0 💤
  1 files      0

Results for commit 36c47c7.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2022

Orc8r Lint & Test

1 135 tests   1 135 ✔️  2m 20s ⏱️
   365 suites         0 💤
       7 files           0

Results for commit 36c47c7.

♻️ This comment has been updated with latest results.

Signed-off-by: VinashakAnkitAman <ankit.aman@radisys.com>
Signed-off-by: VinashakAnkitAman <ankit.aman@radisys.com>
@github-actions github-actions bot added the component: orc8r Orchestrator-related issue label Dec 7, 2022
@VinashakAnkitAman VinashakAnkitAman marked this pull request as ready for review December 7, 2022 13:35
@VinashakAnkitAman VinashakAnkitAman requested a review from a team December 7, 2022 13:35
@VinashakAnkitAman VinashakAnkitAman requested a review from a team as a code owner December 7, 2022 13:35
Signed-off-by: VinashakAnkitAman <ankit.aman@radisys.com>
Signed-off-by: VinashakAnkitAman <ankit.aman@radisys.com>
Signed-off-by: VinashakAnkitAman <ankit.aman@radisys.com>
Signed-off-by: VinashakAnkitAman <ankit.aman@radisys.com>
…ashtables

Signed-off-by: VinashakAnkitAman <ankit.aman@radisys.com>
Signed-off-by: VinashakAnkitAman <ankit.aman@radisys.com>
Copy link
Contributor

@pshelar pshelar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pshelar
Copy link
Contributor

pshelar commented Jan 30, 2023

@VinashakAnkitAman Can you resolve the conflicts to push this commit.

Thanks.

@Sathyaj27
Copy link
Contributor

Lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: agw Access gateway-related issue component: orc8r Orchestrator-related issue size/L Denotes a Pull Request that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants