Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(agw): change remote location of liblfds in docker container #14765

Merged
merged 1 commit into from
Dec 27, 2022
Merged

fix(agw): change remote location of liblfds in docker container #14765

merged 1 commit into from
Dec 27, 2022

Conversation

mpfirrmann
Copy link
Contributor

Signed-off-by: Marco Pfirrmann marco.pfirrmann@tngtech.com

Summary

liblfds is not hosted on GitHub anymore, but on their own servers, see https://www.liblfds.org/pages/git.html. This PR changes its remote locations in the Dockerfiles.

Test Plan

Additional Information

  • This change is backwards-breaking

@mpfirrmann
fix(agw): change remote location of liblfds in docker container
4823ec1 
Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com>
@mpfirrmann mpfirrmann requested a review from a team December 27, 2022 09:38
@mpfirrmann mpfirrmann requested a review from a team as a code owner December 27, 2022 09:38
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines. label Dec 27, 2022
@mpfirrmann mpfirrmann requested review from nstng and removed request for 119Vik December 27, 2022 09:39
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: ci All updates on CI (Jenkins/CircleCi/Github Action) label Dec 27, 2022
@github-actions
Copy link
Contributor

FeG Lint & Test

    2 files  203 suites   40s ⏱️
374 tests 374 ✔️ 0 💤 0 ❌
388 runs  388 ✔️ 0 💤 0 ❌

Results for commit 4823ec1.

@github-actions
Copy link
Contributor

DP Lint & Test

14 tests   14 ✔️  2m 11s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit 4823ec1.

nstng
nstng approved these changes Dec 27, 2022
View reviewed changes
Copy link
Contributor

@nstng nstng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - @rdefosse ping for upstream changes to the OAI repo

@nstng nstng merged commit f4e8846 into magma:master Dec 27, 2022
@mpfirrmann mpfirrmann deleted the pr/adapt_liblfds_docker branch January 17, 2023 06:57
lucasgonze pushed a commit to lucasgonze/magma that referenced this pull request Feb 29, 2024
@mpfirrmann @lucasgonze
fix(agw): change remote location of liblfds in docker container (magm…
02a04ff 
…a#14765)

Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com>

Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nstng nstng nstng approved these changes

Assignees
No one assigned
Labels
component: ci All updates on CI (Jenkins/CircleCi/Github Action) size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mpfirrmann @nstng