-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(agw): change remote location of libgtpnl in docker container #14766
Conversation
Thanks for opening a PR! 💯
Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -138,7 +138,7 @@ RUN git clone --recurse-submodules -b v1.15.0 https://github.com/grpc/grpc && \ | |||
wget https://ftp.gnu.org/gnu/nettle/nettle-2.5.tar.gz && \ | |||
wget https://www.gnupg.org/ftp/gcrypt/gnutls/v3.1/gnutls-3.1.23.tar.xz && \ | |||
git clone https://liblfds.org/git/liblfds && \ | |||
git clone https://git.osmocom.org/libgtpnl && \ | |||
git clone https://gitea.osmocom.org/cellular-infrastructure/libgtpnl/ && \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit³: the "/" at the end is superfluous, right? -> inconsistent with the other entries
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm - see nit (decide for yourself if this is worth a change).
@rdefosse fyi for possible OAI upstream changes
Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com>
b9af4ce
to
9180c7a
Compare
…ma#14766) Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com> Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com>
Signed-off-by: Marco Pfirrmann marco.pfirrmann@tngtech.com
Summary
The
libgtpnl
repo was moved to a new location, see also #14721. This changes the remote location throughout the codebase.Test Plan
Additional Information