fix(agw): change remote location of libgtpnl in docker container #14766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpfirrmann
requested review from
nstng
and removed request for
maxhbr and
pshelar
|
Thanks for opening a PR! 💯
Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
github-actions
bot
added
component: agw
nstng
reviewed
Dec 27, 2022
| @@ -138,7 +138,7 @@ RUN git clone --recurse-submodules -b v1.15.0 https://github.com/grpc/grpc && \ | |||
| wget https://ftp.gnu.org/gnu/nettle/nettle-2.5.tar.gz && \ | |||
| wget https://www.gnupg.org/ftp/gcrypt/gnutls/v3.1/gnutls-3.1.23.tar.xz && \ | |||
| git clone https://liblfds.org/git/liblfds && \ | |||
| git clone https://git.osmocom.org/libgtpnl && \ | |||
| git clone https://gitea.osmocom.org/cellular-infrastructure/libgtpnl/ && \ | |||
There was a problem hiding this comment.
nit³: the "/" at the end is superfluous, right? -> inconsistent with the other entries
Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com>
mpfirrmann
force-pushed
the
pr/adapt_libgtpnl_source
branch
from
b9af4ce
to
9180c7a
Compare
lucasgonze
pushed a commit
to lucasgonze/magma
that referenced
this pull request
Feb 29, 2024
…ma#14766) Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com> Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Marco Pfirrmann marco.pfirrmann@tngtech.com
Summary
The
libgtpnlrepo was moved to a new location, see also #14721. This changes the remote location throughout the codebase.Test Plan
Additional Information