chore: mme compile warnings are reduced #14769

nstng · 2022-12-27T19:53:57Z

Summary

This change reduces compile warnings of mme. See different commits for different warnings.

For bazel build //lte/gateway/c/core:lib_agw_of this reduces the number of compile log lines from ~8.500 to ~890. See attached log files.

01_before.txt
02_after.txt

Test Plan

CI

Additional Information

This change is backwards-breaking

github-actions · 2022-12-27T19:54:13Z

Thanks for opening a PR! 💯

A couple initial guidelines

All commits must be signed off. This is enforced by PR DCO check.
All PR titles must follow the semantic commits format. This is enforced by Semantic PR.

Howto

Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
Checks. All required CI checks must pass before merge.
Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

Contributing Conventions for norms around contributed code

If this is your first Magma PR, also consider reading

Developer Onboarding for onboarding as a new Magma developer
Development Workflow for guidance on your first pull request
CI Checks for points of contact for failing or flaky CI checks
GitHub-to-Slack mappings for Magma maintainers for guidance on how to contact maintainers on Slack

github-actions · 2022-12-27T20:00:49Z

FeG Lint & Test

    2 files 203 suites 40s ⏱️
374 tests 374 ✔️ 0 💤 0 ❌
388 runs 388 ✔️ 0 💤 0 ❌

Results for commit 8166550.

♻️ This comment has been updated with latest results.

github-actions · 2022-12-27T20:18:23Z

DP Lint & Test

14 tests 14 ✔️ 2m 24s ⏱️
  1 suites   0 💤
  1 files   0 ❌

Results for commit 8166550.

♻️ This comment has been updated with latest results.

nstng · 2022-12-28T06:52:36Z

lte/gateway/c/core/oai/tasks/amf/amf_recv.cpp

@@ -51,7 +51,6 @@ status_code_e amf_handle_service_request(
  uint16_t pdu_session_status = 0;
  uint32_t tmsi_stored;
  paging_context_t* paging_ctx = nullptr;
-  guti_and_amf_id_t guti_and_amf_id;


In line 303 guti_and_amf_id_t guti_and_amf_id; is marked by the compiler (and my IDE) as unused - but removing this variable makes //lte/gateway/c/core/oai/test/amf:amf_procedures_test fail with the following logging. If someone has an idea why, please explain :)

exec ${PAGER:-/usr/bin/less} "$0" || exit 1 Executing tests from //lte/gateway/c/core/oai/test/amf:amf_procedures_test ----------------------------------------------------------------------------- Running main() from gmock_main.cc [==========] Running 35 tests from 2 test suites. [----------] Global test environment set-up. [----------] 34 tests from AMFAppProcedureTest [ RUN ] AMFAppProcedureTest.TestRegistrationAuthSecurityModeReject [ OK ] AMFAppProcedureTest.TestRegistrationAuthSecurityModeReject (1 ms) [ RUN ] AMFAppProcedureTest.TestRegistrationAuthSecurityCapabilityMismatch [ OK ] AMFAppProcedureTest.TestRegistrationAuthSecurityCapabilityMismatch (0 ms) [ RUN ] AMFAppProcedureTest.TestRegistrationPlmnMismatch [ OK ] AMFAppProcedureTest.TestRegistrationPlmnMismatch (0 ms) [ RUN ] AMFAppProcedureTest.TestRegistrationProcNoTMSI [ OK ] AMFAppProcedureTest.TestRegistrationProcNoTMSI (1 ms) [ RUN ] AMFAppProcedureTest.TestDeRegistration [ OK ] AMFAppProcedureTest.TestDeRegistration (2 ms) [ RUN ] AMFAppProcedureTest.TestRegistrationProcGutiBased [ OK ] AMFAppProcedureTest.TestRegistrationProcGutiBased (0 ms) [ RUN ] AMFAppProcedureTest.TestRegistrationProcGutiBasedEncryption [ OK ] AMFAppProcedureTest.TestRegistrationProcGutiBasedEncryption (1 ms) [ RUN ] AMFAppProcedureTest.TestMobileUpdatingRegistrationProcGutiBased [ OK ] AMFAppProcedureTest.TestMobileUpdatingRegistrationProcGutiBased (0 ms) [ RUN ] AMFAppProcedureTest.TestPDUSessionSetup [ OK ] AMFAppProcedureTest.TestPDUSessionSetup (1 ms) [ RUN ] AMFAppProcedureTest.TestPDUSessionSetupWithoutContext [ OK ] AMFAppProcedureTest.TestPDUSessionSetupWithoutContext (1 ms) [ RUN ] AMFAppProcedureTest.TestPDUSessionSetupNoDnnNoSlice [ OK ] AMFAppProcedureTest.TestPDUSessionSetupNoDnnNoSlice (1 ms) [ RUN ] AMFAppProcedureTest.TestPDUSessionFailure_dnn_not_subscribed [ OK ] AMFAppProcedureTest.TestPDUSessionFailure_dnn_not_subscribed (0 ms) [ RUN ] AMFAppProcedureTest.TestPDUSession_missing_dnn [ OK ] AMFAppProcedureTest.TestPDUSession_missing_dnn (1 ms) [ RUN ] AMFAppProcedureTest.TestPDUSession_unknown_pdu_session_type [ OK ] AMFAppProcedureTest.TestPDUSession_unknown_pdu_session_type (0 ms) [ RUN ] AMFAppProcedureTest.TestPDUSession_Invalid_PDUSession_Identity [ OK ] AMFAppProcedureTest.TestPDUSession_Invalid_PDUSession_Identity (1 ms) [ RUN ] AMFAppProcedureTest.TestRegistrationProcSUCIExt [ OK ] AMFAppProcedureTest.TestRegistrationProcSUCIExt (0 ms) [ RUN ] AMFAppProcedureTest.TestAuthFailureFromSubscribeDb [ OK ] AMFAppProcedureTest.TestAuthFailureFromSubscribeDb (1 ms) [ RUN ] AMFAppProcedureTest.TestPDUv6SessionSetup [ OK ] AMFAppProcedureTest.TestPDUv6SessionSetup (0 ms) [ RUN ] AMFAppProcedureTest.TestPDUv4v6SessionSetup [ OK ] AMFAppProcedureTest.TestPDUv4v6SessionSetup (1 ms) [ RUN ] AMFAppProcedureTest.ServiceRequestMTWithPDU lte/gateway/c/core/oai/test/amf/test_amf_procedures.cpp:1937: Failure Expected equality of these values: true ue_context->pending_service_response Which is: false lte/gateway/c/core/oai/test/amf/test_amf_procedures.cpp:1940: Failure Expected: (ue_context->amf_ue_ngap_id) != (ue_id), actual: 1 vs 1 lte/gateway/c/core/oai/test/amf/test_amf_procedures.cpp:1977: Failure Value of: expected_Ids == AMFClientServicer::getInstance().msgtype_stack Actual: false Expected: true [ FAILED ] AMFAppProcedureTest.ServiceRequestMTWithPDU (1 ms) [ RUN ] AMFAppProcedureTest.ServiceRequestMTWithoutUplinkDataStatus lte/gateway/c/core/oai/test/amf/test_amf_procedures.cpp:2048: Failure Value of: get_ue_id_from_imsi(amf_app_desc_p, imsi64, &updated_ue_id) Actual: false Expected: true lte/gateway/c/core/oai/test/amf/test_amf_procedures.cpp:2050: Failure Expected equality of these values: REGISTERED_CONNECTED Which is: 2 ue_context->mm_state Which is: 1 lte/gateway/c/core/oai/test/amf/test_amf_procedures.cpp:2053: Failure Expected: (ue_context->amf_ue_ngap_id) != (ue_id), actual: 1 vs 1 lte/gateway/c/core/oai/test/amf/amf_app_test_util.cpp:278: Failure Expected: (nullptr) != (ue_context_p), actual: (nullptr) vs NULL lte/gateway/c/core/oai/test/amf/test_amf_procedures.cpp:2062: Failure Value of: rc == RETURNok Actual: false Expected: true lte/gateway/c/core/oai/test/amf/test_amf_procedures.cpp:2066: Failure Value of: expected_Ids == AMFClientServicer::getInstance().msgtype_stack Actual: false Expected: true [ FAILED ] AMFAppProcedureTest.ServiceRequestMTWithoutUplinkDataStatus (1 ms) [ RUN ] AMFAppProcedureTest.ServiceRequestSignalling lte/gateway/c/core/oai/test/amf/test_amf_procedures.cpp:2136: Failure Value of: get_ue_id_from_imsi(amf_app_desc_p, imsi64, &updated_ue_id) Actual: false Expected: true lte/gateway/c/core/oai/test/amf/test_amf_procedures.cpp:2138: Failure Expected equality of these values: REGISTERED_CONNECTED Which is: 2 ue_context->mm_state Which is: 1 lte/gateway/c/core/oai/test/amf/test_amf_procedures.cpp:2141: Failure Expected: (ue_context->amf_ue_ngap_id) != (ue_id), actual: 1 vs 1 lte/gateway/c/core/oai/test/amf/amf_app_test_util.cpp:278: Failure Expected: (nullptr) != (ue_context_p), actual: (nullptr) vs NULL lte/gateway/c/core/oai/test/amf/test_amf_procedures.cpp:2150: Failure Value of: rc == RETURNok Actual: false Expected: true lte/gateway/c/core/oai/test/amf/test_amf_procedures.cpp:2154: Failure Value of: expected_Ids == AMFClientServicer::getInstance().msgtype_stack Actual: false Expected: true [ FAILED ] AMFAppProcedureTest.ServiceRequestSignalling (0 ms) [ RUN ] AMFAppProcedureTest.ImplicitDeregDuplicateSuciReg [ OK ] AMFAppProcedureTest.ImplicitDeregDuplicateSuciReg (1 ms) [ RUN ] AMFAppProcedureTest.ServiceRequestWrongTMSI [ OK ] AMFAppProcedureTest.ServiceRequestWrongTMSI (1 ms) [ RUN ] AMFAppProcedureTest.ServiceRequestSignalWithPDU lte/gateway/c/core/oai/test/amf/test_amf_procedures.cpp:2562: Failure Value of: get_ue_id_from_imsi(amf_app_desc_p, imsi64, &updated_ue_id) Actual: false Expected: true lte/gateway/c/core/oai/test/amf/amf_app_test_util.cpp:278: Failure Expected: (nullptr) != (ue_context_p), actual: (nullptr) vs NULL lte/gateway/c/core/oai/test/amf/test_amf_procedures.cpp:2570: Failure Value of: rc == RETURNok Actual: false Expected: true lte/gateway/c/core/oai/test/amf/test_amf_procedures.cpp:2576: Failure Value of: rc == RETURNok Actual: false Expected: true lte/gateway/c/core/oai/test/amf/test_amf_procedures.cpp:2582: Failure Value of: rc == RETURNok Actual: false Expected: true lte/gateway/c/core/oai/test/amf/test_amf_procedures.cpp:2592: Failure Value of: rc == RETURNok Actual: false Expected: true lte/gateway/c/core/oai/test/amf/test_amf_procedures.cpp:2594: Failure Value of: expected_Ids == AMFClientServicer::getInstance().msgtype_stack Actual: false Expected: true [ FAILED ] AMFAppProcedureTest.ServiceRequestSignalWithPDU (1 ms) [ RUN ] AMFAppProcedureTest.PeriodicRegistraionNoTmsi [ OK ] AMFAppProcedureTest.PeriodicRegistraionNoTmsi (1 ms) [ RUN ] AMFAppProcedureTest.ReRegistraion lte/gateway/c/core/oai/test/amf/test_amf_procedures.cpp:2777: Failure Value of: expected_Ids == AMFClientServicer::getInstance().msgtype_stack Actual: false Expected: true [ FAILED ] AMFAppProcedureTest.ReRegistraion (1 ms) [ RUN ] AMFAppProcedureTest.SctpShutWithServiceRequest lte/gateway/c/core/oai/test/amf/test_amf_procedures.cpp:2893: Failure Value of: get_ue_id_from_imsi(amf_app_desc_p, imsi64, &updated_ue_id) Actual: false Expected: true lte/gateway/c/core/oai/test/amf/amf_app_test_util.cpp:278: Failure Expected: (nullptr) != (ue_context_p), actual: (nullptr) vs NULL lte/gateway/c/core/oai/test/amf/test_amf_procedures.cpp:2901: Failure Value of: rc == RETURNok Actual: false Expected: true lte/gateway/c/core/oai/test/amf/test_amf_procedures.cpp:2907: Failure Value of: rc == RETURNok Actual: false Expected: true lte/gateway/c/core/oai/test/amf/test_amf_procedures.cpp:2913: Failure Value of: rc == RETURNok Actual: false Expected: true lte/gateway/c/core/oai/test/amf/test_amf_procedures.cpp:2923: Failure Value of: rc == RETURNok Actual: false Expected: true lte/gateway/c/core/oai/test/amf/test_amf_procedures.cpp:2925: Failure Value of: expected_Ids == AMFClientServicer::getInstance().msgtype_stack Actual: false Expected: true [ FAILED ] AMFAppProcedureTest.SctpShutWithServiceRequest (1 ms) [ RUN ] AMFAppProcedureTest.TestAuthFailureFromSubscribeDbLock [ OK ] AMFAppProcedureTest.TestAuthFailureFromSubscribeDbLock (0 ms) [ RUN ] AMFAppProcedureTest.TestPDUSession_LocationUpdateFail [ OK ] AMFAppProcedureTest.TestPDUSession_LocationUpdateFail (0 ms) [ RUN ] AMFAppProcedureTest.TestPDUSessionResourceModify [ OK ] AMFAppProcedureTest.TestPDUSessionResourceModify (1 ms) [ RUN ] AMFAppProcedureTest.RegistrationAfterFourRegAcceptMsgs lte/gateway/c/core/oai/test/amf/test_amf_procedures.cpp:3199: Failure Value of: get_ue_id_from_imsi(amf_app_desc_p, imsi64, &updated_ue_id) Actual: false Expected: true lte/gateway/c/core/oai/test/amf/test_amf_procedures.cpp:3204: Failure Expected: (ue_context->amf_ue_ngap_id) != (ue_id), actual: 1 vs 1 lte/gateway/c/core/oai/test/amf/amf_app_test_util.cpp:278: Failure Expected: (nullptr) != (ue_context_p), actual: (nullptr) vs NULL lte/gateway/c/core/oai/test/amf/test_amf_procedures.cpp:3213: Failure Value of: rc == RETURNok Actual: false Expected: true lte/gateway/c/core/oai/test/amf/test_amf_procedures.cpp:3217: Failure Value of: expected_Ids == AMFClientServicer::getInstance().msgtype_stack Actual: false Expected: true [ FAILED ] AMFAppProcedureTest.RegistrationAfterFourRegAcceptMsgs (0 ms) [ RUN ] AMFAppProcedureTest.TestPDUSessionResourceModifyDeletion [ OK ] AMFAppProcedureTest.TestPDUSessionResourceModifyDeletion (1 ms) [ RUN ] AMFAppProcedureTest.GnbInitiatedNGReset [ OK ] AMFAppProcedureTest.GnbInitiatedNGReset (0 ms) [----------] 34 tests from AMFAppProcedureTest (22 ms total) [----------] 1 test from test_t3592abort [ RUN ] test_t3592abort.test_pdu_session_release_notify_smf [ OK ] test_t3592abort.test_pdu_session_release_notify_smf (0 ms) [----------] 1 test from test_t3592abort (0 ms total) [----------] Global test environment tear-down [==========] 35 tests from 2 test suites ran. (22 ms total) [ PASSED ] 28 tests. [ FAILED ] 7 tests, listed below: [ FAILED ] AMFAppProcedureTest.ServiceRequestMTWithPDU [ FAILED ] AMFAppProcedureTest.ServiceRequestMTWithoutUplinkDataStatus [ FAILED ] AMFAppProcedureTest.ServiceRequestSignalling [ FAILED ] AMFAppProcedureTest.ServiceRequestSignalWithPDU [ FAILED ] AMFAppProcedureTest.ReRegistraion [ FAILED ] AMFAppProcedureTest.SctpShutWithServiceRequest [ FAILED ] AMFAppProcedureTest.RegistrationAfterFourRegAcceptMsgs 7 FAILED TESTS

Just in case someone wants to dig deeper: This struct was added in this change in this PR. Most of the relevant code was removed in this PR, with the exception of four definitions.

The tests pass even if the line guti_and_amf_id_t guti_and_amf_id; is moved to line 623, the very end of the function amf_handle_registration_request. Therefore it is certainly not used inside of this function. Just adding a sleep also does not have an effect, so it is not just the time to create the struct that is relevant.

rsarwad · 2022-12-28T14:59:27Z

lte/gateway/c/core/oai/tasks/mme_app/mme_app_context.cpp

@@ -1421,7 +1422,7 @@ bool is_mme_ue_context_network_access_mode_packet_only(
  OAILOG_FUNC_IN(LOG_MME_APP);
  if (ue_context_p == NULL) {
    OAILOG_CRITICAL(LOG_MME_APP, "**** Abnormal- UE context is null.****\n");
-    OAILOG_FUNC_RETURN(LOG_MME_APP, RETURNerror);
+    OAILOG_FUNC_RETURN(LOG_MME_APP, RETURNerror != 0);


Can we return "false" as RETURNerror != 0 will also return false. With returning false we can skip evaluation

Just to be sure: do you mean changing RETURNerror != 0 to false or do you mean completely replacing OAILOG_FUNC_RETURN(LOG_MME_APP, RETURNerror != 0); with return false?
The second case would imply to me that OAILOG_FUNC_RETURN should be replaced everywhere. What is the purpose of this function? Looks to me like an interceptor that could be used for logging - but currently just does nothing.

I meant the statement to be as "OAILOG_FUNC_RETURN(LOG_MME_APP, false).
Yes logically in fun, is_mme_ue_context_network_access_mode_packet_only() it checks whether "network_access_mode" is set to "NAM_ONLY_PACKET". This function could have been replaced with checking the network_access_mode set to "NAM_ONLY_PACKET"

changed and rebased into b97415161d chore: "warning: enum constant in boolean context [-Wint-in-bool-context]" II is fixed - same for comments below

rsarwad · 2022-12-28T14:59:49Z

lte/gateway/c/core/oai/tasks/mme_app/mme_app_context.cpp

@@ -1461,7 +1462,7 @@ bool mme_ue_context_get_ue_sgs_vlr_reliable(mme_ue_s1ap_id_t mme_ue_s1ap_id) {
  ue_context_p = mme_ue_context_exists_mme_ue_s1ap_id(mme_ue_s1ap_id);
  if (ue_context_p == NULL) {
    OAILOG_CRITICAL(LOG_MME_APP, "**** Abnormal- UE context is null.****\n");
-    OAILOG_FUNC_RETURN(LOG_MME_APP, RETURNerror);
+    OAILOG_FUNC_RETURN(LOG_MME_APP, RETURNerror != 0);


Same as above

rsarwad · 2022-12-28T15:00:22Z

lte/gateway/c/core/oai/tasks/mme_app/mme_app_context.cpp

@@ -1499,7 +1500,7 @@ bool mme_ue_context_get_ue_sgs_neaf(mme_ue_s1ap_id_t mme_ue_s1ap_id) {
  ue_context_p = mme_ue_context_exists_mme_ue_s1ap_id(mme_ue_s1ap_id);
  if (ue_context_p == NULL) {
    OAILOG_CRITICAL(LOG_MME_APP, "**** Abnormal- UE context is null.****\n");
-    OAILOG_FUNC_RETURN(LOG_MME_APP, RETURNerror);
+    OAILOG_FUNC_RETURN(LOG_MME_APP, RETURNerror != 0);


Same as above

rsarwad · 2022-12-28T15:27:48Z

lte/gateway/c/core/oai/tasks/nas/emm/msg/AttachAccept.cpp

@@ -99,7 +99,7 @@ int decode_attach_accept(attach_accept_msg* attach_accept, uint8_t* buffer,
      case ATTACH_ACCEPT_LOCATION_AREA_IDENTIFICATION_IEI:
        if ((decoded_result = decode_location_area_identification_ie(
                 &attach_accept->locationareaidentification,
-                 ATTACH_ACCEPT_LOCATION_AREA_IDENTIFICATION_IEI,
+                 ATTACH_ACCEPT_LOCATION_AREA_IDENTIFICATION_IEI != 0,


This condition always indicate that IE is present. Can we check like here, https://github.com/magma/magma/blob/master/lte/gateway/c/core/oai/tasks/nas/ies/EmmCause.cpp#L37
@pruthvihebbani can we have any other better approach

I am not sure if I understand correctly (I am not that fluent in the mme business logic) - but, is this related to the reduction of warnings? If not, I would keep it out of scope here.

In my opinion, let's retain your changes because earlier also the condition always evaluates to true. On failing to receive expected IE, the macro "CHECK_IEI_DECODER" will take care to return error, "TLV_UNEXPECTED_IEI"

rsarwad · 2022-12-29T03:46:31Z

lte/gateway/c/core/oai/tasks/s1ap/s1ap_mme_handlers.cpp

@@ -5037,7 +5032,7 @@ bool is_all_erabId_same(S1ap_PathSwitchRequest_t* container) {
                             true);
  if (!ie) {
    OAILOG_ERROR(LOG_S1AP, "Incorrect IE \n");
-    return RETURNerror;
+    return RETURNerror != 0;


Can we return false?

rsarwad

LGTM

pruthvihebbani

LGTM

.bazelrc

lte/gateway/c/core/oai/lib/openflow/controller/GTPApplication.cpp

LKreutzer · 2023-01-03T12:23:24Z

lte/gateway/c/core/oai/tasks/amf/amf_recv.cpp

@@ -51,7 +51,6 @@ status_code_e amf_handle_service_request(
  uint16_t pdu_session_status = 0;
  uint32_t tmsi_stored;
  paging_context_t* paging_ctx = nullptr;
-  guti_and_amf_id_t guti_and_amf_id;


Just in case someone wants to dig deeper: This struct was added in this change in this PR. Most of the relevant code was removed in this PR, with the exception of four definitions.

The tests pass even if the line guti_and_amf_id_t guti_and_amf_id; is moved to line 623, the very end of the function amf_handle_registration_request. Therefore it is certainly not used inside of this function. Just adding a sleep also does not have an effect, so it is not just the time to create the struct that is relevant.

.bazelrc

Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com>

…* [-Wwrite-strings]" is fixed Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com>

Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com>

… argument n has type long int [-Wformat=]" is fixed Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com>

…ext]" is fixed Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com>

…ext]" II is fixed Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com>

Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com>

* chore: warnings from compiling external libs are excluded Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com> * chore: "warning: ISO C++ forbids converting a string constant to char* [-Wwrite-strings]" is fixed Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com> * chore: "warning: unused variable foo [-Wunused-variable]" is fixed Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com> * chore: "warning: format %u expects argument of type unsigned int, but argument n has type long int [-Wformat=]" is fixed Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com> * chore: "warning: enum constant in boolean context [-Wint-in-bool-context]" is fixed Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com> * chore: "warning: enum constant in boolean context [-Wint-in-bool-context]" II is fixed Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com> * chore: miscellaneous warnings are fixed Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com> Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com>

nstng requested review from a team, vktng and ardzoht December 27, 2022 19:53

pull-request-size bot added the size/L Denotes a Pull Request that changes 100-499 lines. label Dec 27, 2022

github-actions bot added the component: agw Access gateway-related issue label Dec 27, 2022

nstng self-assigned this Dec 27, 2022

nstng force-pushed the reduce_mme_compile_warnings branch 3 times, most recently from 68ab96a to f26bfd0 Compare December 27, 2022 22:47

nstng commented Dec 28, 2022

View reviewed changes

rsarwad reviewed Dec 29, 2022

View reviewed changes

nstng force-pushed the reduce_mme_compile_warnings branch from f26bfd0 to d5fd40d Compare December 29, 2022 15:00

rsarwad approved these changes Dec 29, 2022

View reviewed changes

pruthvihebbani approved these changes Jan 2, 2023

View reviewed changes

LKreutzer requested review from LKreutzer and removed request for vktng January 3, 2023 10:04

LKreutzer requested changes Jan 3, 2023

View reviewed changes

nstng force-pushed the reduce_mme_compile_warnings branch from d5fd40d to 82edb7c Compare January 3, 2023 14:25

nstng requested a review from LKreutzer January 3, 2023 14:26

LKreutzer reviewed Jan 3, 2023

View reviewed changes

.bazelrc Outdated Show resolved Hide resolved

nstng added 6 commits January 3, 2023 15:32

chore: warnings from compiling external libs are excluded

78f2ceb

Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com>

chore: "warning: ISO C++ forbids converting a string constant to char…

4dce3c9

…* [-Wwrite-strings]" is fixed Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com>

chore: "warning: unused variable foo [-Wunused-variable]" is fixed

68197fb

Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com>

chore: "warning: format %u expects argument of type unsigned int, but…

a670d4a

… argument n has type long int [-Wformat=]" is fixed Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com>

chore: "warning: enum constant in boolean context [-Wint-in-bool-cont…

735e6fb

…ext]" is fixed Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com>

chore: "warning: enum constant in boolean context [-Wint-in-bool-cont…

2f60cf8

…ext]" II is fixed Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com>

chore: miscellaneous warnings are fixed

8166550

Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com>

nstng force-pushed the reduce_mme_compile_warnings branch from 82edb7c to 8166550 Compare January 3, 2023 14:32

LKreutzer approved these changes Jan 3, 2023

View reviewed changes

nstng merged commit 4916020 into magma:master Jan 3, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: mme compile warnings are reduced #14769

chore: mme compile warnings are reduced #14769

nstng commented Dec 27, 2022

github-actions bot commented Dec 27, 2022

github-actions bot commented Dec 27, 2022 •

edited

github-actions bot commented Dec 27, 2022 •

edited

nstng Dec 28, 2022

LKreutzer Jan 3, 2023

rsarwad Dec 28, 2022

nstng Dec 29, 2022

rsarwad Dec 29, 2022

nstng Dec 29, 2022

rsarwad Dec 28, 2022

rsarwad Dec 28, 2022

rsarwad Dec 28, 2022

nstng Dec 29, 2022

rsarwad Dec 29, 2022

rsarwad Dec 29, 2022

rsarwad left a comment

pruthvihebbani left a comment

LKreutzer Jan 3, 2023

chore: mme compile warnings are reduced #14769

chore: mme compile warnings are reduced #14769

Conversation

nstng commented Dec 27, 2022

Summary

Test Plan

Additional Information

github-actions bot commented Dec 27, 2022

Howto

More info

github-actions bot commented Dec 27, 2022 • edited

FeG Lint & Test

github-actions bot commented Dec 27, 2022 • edited

DP Lint & Test

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rsarwad left a comment

Choose a reason for hiding this comment

pruthvihebbani left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Dec 27, 2022 •

edited

github-actions bot commented Dec 27, 2022 •

edited