Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ci): execute long extended tests in CI run #14799

Merged
merged 3 commits into from
Jan 5, 2023
Merged

feat(ci): execute long extended tests in CI run #14799

merged 3 commits into from
Jan 5, 2023

Conversation

mpfirrmann
Copy link
Contributor

Summary

The extended LTE integration tests categorized as "long" due to their extended waiting periods are not executed in test runs based on a containerized AGW despite them in general being green. As we run the different integration test targets in parallel, the long waiting times should not be an issue and these tests should run in CI.

Test Plan

Additional Information

  • This change is backwards-breaking

@mpfirrmann
feat(agw): include long extended tests to containerized integ_test
629dd39 
Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com>
@mpfirrmann
feat(ci): add long extended tests as option in CI run
4e3663f 
Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com>
@mpfirrmann mpfirrmann requested review from nstng and a team January 4, 2023 18:47
@mpfirrmann mpfirrmann self-assigned this Jan 4, 2023
@mpfirrmann mpfirrmann requested a review from a team as a code owner January 4, 2023 18:47
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines. label Jan 4, 2023
@github-actions github-actions bot added component: agw Access gateway-related issue component: ci All updates on CI (Jenkins/CircleCi/Github Action) labels Jan 4, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2023

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@mpfirrmann
feat(ci): execute long extended tests in CI run
c143458 
Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com>
@mpfirrmann mpfirrmann force-pushed the pr/conatinerized_long_extended branch from 123e2b3 to c143458 Compare January 4, 2023 18:53
@pull-request-size pull-request-size bot added size/M Denotes a PR that changes 30-99 lines. and removed size/S Denotes a PR that changes 10-29 lines. labels Jan 4, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2023

FeG Lint & Test

    2 files  203 suites   40s ⏱️
374 tests 374 ✔️ 0 💤 0 ❌
388 runs  388 ✔️ 0 💤 0 ❌

Results for commit c143458.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2023

DP Lint & Test

14 tests   14 ✔️  2m 18s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit c143458.

rsarwad
rsarwad approved these changes Jan 5, 2023
View reviewed changes
Copy link
Contributor

@rsarwad rsarwad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes related to agw-integtests look good.

nstng
nstng approved these changes Jan 5, 2023
View reviewed changes
Copy link
Contributor

@nstng nstng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nstng nstng merged commit d3001d2 into magma:master Jan 5, 2023
@nstng nstng mentioned this pull request Jan 5, 2023
Merged
1 task
@nstng nstng linked an issue Jan 5, 2023 that may be closed by this pull request
CI support for dockerized agw fix tests that do not run out of the box on ci #14124
Closed
@mpfirrmann mpfirrmann deleted the pr/conatinerized_long_extended branch January 17, 2023 06:57
lucasgonze pushed a commit to lucasgonze/magma that referenced this pull request Feb 29, 2024
@mpfirrmann @lucasgonze
feat(ci): execute long extended tests in CI run (magma#14799)
26baa89 
* feat(agw): include long extended tests to containerized integ_test

Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com>

* feat(ci): add long extended tests as option in CI run

Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com>

* feat(ci): execute long extended tests in CI run

Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com>

Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsarwad rsarwad rsarwad approved these changes

@nstng nstng nstng approved these changes

Assignees

@mpfirrmann mpfirrmann

Labels
component: agw Access gateway-related issue component: ci All updates on CI (Jenkins/CircleCi/Github Action) size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI support for dockerized agw fix tests that do not run out of the box on ci
3 participants
@mpfirrmann @rsarwad @nstng