Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: envoy service is started for containerized integ tests #14820

Merged
merged 1 commit into from
Jan 17, 2023

Conversation

nstng
Copy link
Contributor

@nstng nstng commented Jan 10, 2023

Signed-off-by: Nils Semmelrock nils.semmelrock@tngtech.com

Summary

Approach to fix extended tests added in #14808. We see failing he tests while getting the envoy config - e.g., https://github.com/magma/magma/runs/10576007895.

In the documentation for a local setup magma_dp@envoy is started - this is not happening in CI. (see here)

Approach here: start magma_dp@envoy for CI runs

Test Plan

run extended tests on fork - three consecutive green runs:

Additional Information

  • This change is backwards-breaking

Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com>
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines. label Jan 10, 2023
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: agw Access gateway-related issue label Jan 10, 2023
@github-actions
Copy link
Contributor

FeG Lint & Test

    2 files  203 suites   40s ⏱️
374 tests 374 ✔️ 0 💤 0
388 runs  388 ✔️ 0 💤 0

Results for commit 32a4337.

@github-actions
Copy link
Contributor

DP Lint & Test

14 tests   14 ✔️  3m 16s ⏱️
  1 suites    0 💤
  1 files      0

Results for commit 32a4337.

@nstng nstng self-assigned this Jan 11, 2023
@nstng nstng marked this pull request as ready for review January 12, 2023 09:37
@nstng nstng requested a review from a team as a code owner January 12, 2023 09:37
@nstng nstng requested a review from pshelar January 12, 2023 09:37
@nstng nstng merged commit da84679 into magma:master Jan 17, 2023
lucasgonze pushed a commit to lucasgonze/magma that referenced this pull request Feb 29, 2024
…14820)

Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com>

Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: agw Access gateway-related issue size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants