feat(agw): add architecture value to helm charts to support ARM deploy… #14863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a PR! 💯
Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
|
✔️ The Semantic PR check ended with status success. See instructions on formatting your commit and pull request titles. |
jblakley
changed the title
…yment Signed-off-by: Jim Blakley <jblake1@andrew.cmu.edu>
jblakley
force-pushed
the
agwc-helm-fixes
branch
from
896ecf1
to
988e1b9
Compare
|
Workflows should now be running on the PR - some workflows require manual approval to run for first time contributors. Thank you for contributing. |
lucasgonze
pushed a commit
to lucasgonze/magma
that referenced
this pull request
Feb 29, 2024
…yment (magma#14863) Signed-off-by: Jim Blakley <jblake1@andrew.cmu.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jim Blakley jblake1@andrew.cmu.edu
Summary
Updated agwc-helm-charts to add a value "arch" and modified the templates to use this value on image pull. This enables helm to pull the ARM images rather than the x86 images on a
helm install. README was updated accordingly.The code submitted also takes out the installation of the GW_CHALLENGE_KEY. This was not working correctly and was done manually as described here: https://docs.magmaindia.org/deploy/agw/install-agw-helm.html.
Test Plan
Tested on an ARM64 Ampere server. AGW has been deployed in operation in our network for over a week with no issues. (including eNB and connected UE). Tested
helm install --dry-runto verify that x86 images urls remain correct.Additional Information