fix(agw): Address mypy errors in lte/gateway/python/

[voisey]

Summary

Fixes all 60 mypy errors in lte/gateway/python. The errors can be looked at locally by running cd $MAGMA_ROOT && mypy lte/gateway/python/. For this, I have been using mypy version 0.991, which is the same as is running in the CI.

Note that in pipelined_test_util.py, I converted SubTest from a named tuple into a dataclass, following the discussion here.

Test Plan

• Unit tests are green locally: bazel test //lte/gateway/python/...
• Sudo tests are green locally: bazel/scripts/run_sudo_tests.sh
• CI

[github-actions]

Thanks for opening a PR! 💯

A couple initial guidelines

• All commits must be signed off. This is enforced by PR DCO check.
• All PR titles must follow the semantic commits format. This is enforced by Semantic PR.

Howto

• Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
• Checks. All required CI checks must pass before merge.
• Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

• Contributing Conventions for norms around contributed code

If this is your first Magma PR, also consider reading

• Developer Onboarding for onboarding as a new Magma developer
• Development Workflow for guidance on your first pull request
• CI Checks for points of contact for failing or flaky CI checks
• GitHub-to-Slack mappings for Magma maintainers for guidance on how to contact maintainers on Slack

[github-actions]

FeG Lint & Test

    2 files  203 suites   40s ⏱️
374 tests 374 ✔️ 0 💤 0 ❌
388 runs  388 ✔️ 0 💤 0 ❌

Results for commit be10a07.

♻️ This comment has been updated with latest results.

[github-actions]

DP Lint & Test

14 tests   14 ✔️  2m 10s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit be10a07.

♻️ This comment has been updated with latest results.

[nstng]

overall lgtml. when I run mypy locally I still get one error

~/magma$ pip3 show mypy
Name: mypy
Version: 0.991

~/magma$ python3 -m mypy lte/gateway/python/
...
lte/gateway/python/integ_tests/gateway/rpc.py:20: error: Module "orc8r.protos.mconfig" has no attribute "mconfigs_pb2"  [attr-defined]
...
Found 1 error in 1 file (checked 674 source files)

Any idea for this? There are a lot of proto imports that are not flagged.

[nstng]

Any idea for this? There are a lot of proto imports that are not flagged.

Looked into this offline in pairing. Looks like mypy (and python) think the import is working because there is an (unrelated) folder orc8r/protos/mconfig without any py files -> something like an empty import.
This should be excluded from mypy checks with a respective comment.

[github-actions]

Oops! Looks like you failed the AGW Build & Format Python.

Howto

• Instructions on running the formatter and linter locally are provided in the format AGW doc
• Guide to the different CI checks and resolution guidelines

♻️ Updated: ✅ The check is passing the AGW Build & Format Python after the last commit.

[voisey]

Thanks for flagging this @nstng. For some reason that error only shows up for me sometimes, so I've excluded it for now. The same import is used several times in orc8r/gateway/python, but I don't see mypy errors for these cases when I run mypy orc8r/gateway/python. However, I do get errors in some cases when I run mypy on the specific files, but not always... I propose getting this PR merged and then investigating this further with a potential follow-up. Does that sound okay to you?

[nstng]

I propose getting this PR merged and then investigating this further with a potential follow-up. Does that sound okay to you?

Yes, sounds good. Checked the exclude -> no more errors for me :)