Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): Run apt update in pylint job #14901

Merged
merged 1 commit into from
Jan 27, 2023
Merged

fix(ci): Run apt update in pylint job #14901

merged 1 commit into from
Jan 27, 2023

Conversation

LKreutzer
Copy link
Contributor

@LKreutzer LKreutzer commented Jan 27, 2023 •
edited

Signed-off-by: Lars Kreutzer lars.kreutzer@tngtech.com

Summary

Test Plan

Additional Information

  • This change is backwards-breaking

@LKreutzer
fix(ci): Run apt update in pylint job
9551e33 
Signed-off-by: Lars Kreutzer <lars.kreutzer@tngtech.com>
@LKreutzer LKreutzer added the component: ci All updates on CI (Jenkins/CircleCi/Github Action) label Jan 27, 2023
@LKreutzer LKreutzer requested a review from nstng January 27, 2023 11:12
@LKreutzer LKreutzer self-assigned this Jan 27, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines. label Jan 27, 2023
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions
Copy link
Contributor

DP Lint & Test

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 9551e33.

nstng
nstng approved these changes Jan 27, 2023
View reviewed changes
Copy link
Contributor

@nstng nstng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/magma/magma/actions/runs/4023941995/jobs/6915402531 lgtm

@LKreutzer LKreutzer marked this pull request as ready for review January 27, 2023 11:19
@LKreutzer LKreutzer requested a review from a team as a code owner January 27, 2023 11:19
@LKreutzer LKreutzer enabled auto-merge (squash) January 27, 2023 11:20
@LKreutzer LKreutzer merged commit 8ee45d9 into magma:master Jan 27, 2023
lucasgonze pushed a commit to lucasgonze/magma that referenced this pull request Feb 29, 2024
@LKreutzer @lucasgonze
fix(ci): Run apt update in pylint job (magma#14901)
ca92692 
Signed-off-by: Lars Kreutzer <lars.kreutzer@tngtech.com>

Signed-off-by: Lars Kreutzer <lars.kreutzer@tngtech.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@voisey voisey voisey approved these changes

@nstng nstng nstng approved these changes

Assignees

@LKreutzer LKreutzer

Labels
component: ci All updates on CI (Jenkins/CircleCi/Github Action) size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@LKreutzer @voisey @nstng