fix(ci): Fix envoy_controller link for integ tests

[LKreutzer]

Signed-off-by: Lars Kreutzer lars.kreutzer@tngtech.com

Summary

• The LTE Make dev build integ tests are broken due to an incorrect link to the envoy_controller executable in the magma_dev VM.
• This PR fixes the link by specifying the bin folder.
• The change to the go_build variable is not strictly necessary, but it removes a doubled slash in the linking of the envoy_controller. The variable is not used anywhere else.
• The bug was found during the testing of chore: Run integ tests directly without Make #14912

Test Plan

• Link to LTE Make dev build integ workflow runs
  • Only test_3485_timer_for_default_bearer_with_mme_restart failed.
  • Fully green run
• Manual testing: Build VM, run cd magma/lte/gateway && make, check that the executable is there and that it can be started.

Additional Information

• This change is backwards-breaking

[github-actions]

Thanks for opening a PR! 💯

A couple initial guidelines

• All commits must be signed off. This is enforced by PR DCO check.
• All PR titles must follow the semantic commits format. This is enforced by Semantic PR.

Howto

• Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
• Checks. All required CI checks must pass before merge.
• Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

• Contributing Conventions for norms around contributed code

If this is your first Magma PR, also consider reading

• Developer Onboarding for onboarding as a new Magma developer
• Development Workflow for guidance on your first pull request
• CI Checks for points of contact for failing or flaky CI checks
• GitHub-to-Slack mappings for Magma maintainers for guidance on how to contact maintainers on Slack

[github-actions]

FeG Lint & Test

    2 files  203 suites   40s ⏱️
374 tests 374 ✔️ 0 💤 0 ❌
388 runs  388 ✔️ 0 💤 0 ❌

Results for commit 37566b1.

[github-actions]

DP Lint & Test

14 tests   14 ✔️  2m 16s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit 37566b1.