fix(agw): restart mme as a single service for one single containerize… #14946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/L
|
Thanks for opening a PR! 💯
Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
mpfirrmann
force-pushed
the
pr/mme_restart_3485
branch
from
9bf60d3
to
77b7e52
Compare
pull-request-size
bot
added
size/M
|
Oops! Looks like you failed the Howto
♻️ Updated: ✅ The check is passing the AGW Build & Format Python after the last commit. |
mpfirrmann
force-pushed
the
pr/mme_restart_3485
branch
from
77b7e52
to
071a2bd
Compare
1 task
| self._s1ap_wrapper.magmad_util.restart_services( | ||
|
|
||
| # MME is explicitly restarted as a single service here, see comment | ||
| # in the function. |
There was a problem hiding this comment.
It's not ideal to refer to a comment in another function at this line. If the comment in restart_single_service ever goes away or changes, the comment in this file will be out of date. May be say instead e.g.
# MME is explicitly restarted as a single service here to avoid a race condition between the container restarts and the T3485 timer
| # Since we hard code these intedependent container restarts for testing | ||
| # only, one test is executed with only a MME restart to keep it green; | ||
| # Test3485TimerForDefaultBearerWithMmeRestart. | ||
| # |
There was a problem hiding this comment.
Should we move this comment to the document string above? That way it is more easily visible, e.g. if a developer uses the quick documentation lookup feature in an IDE?
|
I successfully ran the tests locally and the changes LGTM. |
nstng
approved these changes
Feb 6, 2023
…d AGW integ test Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com>
mpfirrmann
force-pushed
the
pr/mme_restart_3485
branch
from
071a2bd
to
a7aeddf
Compare
lucasgonze
pushed a commit
to lucasgonze/magma
that referenced
this pull request
Feb 29, 2024
…d AGW integ test (magma#14946) Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…d AGW integ test
Signed-off-by: Marco Pfirrmann marco.pfirrmann@tngtech.com
Summary
Analyzing the failing S1AP integration tests based on a containerized AGW,
s1aptests/test_3485_timer_for_default_bearer_with_mme_restart.pyfails consistently. We suspect a race condition between the container restarts and the T3485 timer. For this test only, we only restart the MME container to mitigate the race condition.Background information:
In the systemd-base AGW, magma services do have a cascading restart mechanism: if one of them restarts, several other restart as well. This was mirrored in the S1AP test framework for the containerized AGW case. In production, every container is on its own. We now restart the mme container on its own for this particular test.
Test Plan
Additional Information