Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Require codeowner for go.mod changes #14992

Merged
merged 1 commit into from
Feb 13, 2023

Conversation

LKreutzer
Copy link
Contributor

@LKreutzer LKreutzer commented Feb 10, 2023

Signed-off-by: Lars Kreutzer lars.kreutzer@tngtech.com

Summary

Test Plan

  • Verify that all go.mod files are owned by the approver groups.

Additional Information

  • This change is backwards-breaking

Signed-off-by: Lars Kreutzer <lars.kreutzer@tngtech.com>
@LKreutzer LKreutzer self-assigned this Feb 10, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines. label Feb 10, 2023
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions
Copy link
Contributor

DP Lint & Test

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit b4f17b4.

@LKreutzer LKreutzer marked this pull request as ready for review February 10, 2023 12:41
@LKreutzer LKreutzer requested a review from a team as a code owner February 10, 2023 12:41
Copy link
Contributor

@pshelar pshelar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@LKreutzer LKreutzer merged commit f1c5291 into magma:master Feb 13, 2023
lucasgonze pushed a commit to lucasgonze/magma that referenced this pull request Feb 29, 2024
Signed-off-by: Lars Kreutzer <lars.kreutzer@tngtech.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate CODEOWNERS file settings for generated Go files
2 participants