chore: Require codeowner for go.mod changes #14992
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lars Kreutzer lars.kreutzer@tngtech.com
Summary
go.mod
files are not owned by any codeowner group. Instead they are handled, together with the generated files, e.g.go.sum
, by the non-existent@ghost
group.go.mod
files are generated, however they should be reviewed as they define the pinning of dependencies for Go builds.go.mod
files from the non-existent@ghost
group and implicitly move them into the codeowner groups that own the folders where they are located.go.mod
files are located incloud
folders, which means that they are automatically owned via*/cloud/ @magma/approvers-cloud
.go.mod
files are located in folders owned by codeowners.CODEOWNERS
file settings for generated Go files #14868Test Plan
go.mod
files are owned by the approver groups.Additional Information