Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add FeG docker page to sidebars #15017

Merged
merged 1 commit into from
Feb 15, 2023
Merged

Conversation

voisey
Copy link
Contributor

@voisey voisey commented Feb 15, 2023

Summary

Related to #14958. Fixes the fact that the "FeG Docker Setup" page is not displayed in the sidebars. This fixes it for master and the supported releases (1.7, 1.8). This also changes the id in the relevant pages so it matches the convention described in #14965.

Test Plan

  • Ran cd $MAGMA_ROOT/docs && make dev successfully locally
  • Checked that for each of the modified versions (1.7, 1.8, master), the page appears in the sidebar as expected

Signed-off-by: Cameron Voisey <cameron.voisey@tngtech.com>
@voisey voisey requested a review from a team as a code owner February 15, 2023 16:01
@voisey voisey requested a review from tmdzk February 15, 2023 16:01
@voisey voisey self-assigned this Feb 15, 2023
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines. label Feb 15, 2023
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: docs Documentation-related issue label Feb 15, 2023
@github-actions
Copy link
Contributor

DP Lint & Test

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit b24de68.

@voisey voisey merged commit 5032989 into magma:master Feb 15, 2023
lucasgonze pushed a commit to lucasgonze/magma that referenced this pull request Feb 29, 2024
Signed-off-by: Cameron Voisey <cameron.voisey@tngtech.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: docs Documentation-related issue size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants