Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): Unblock CI by skipping broken NMS tests #15128

Merged
merged 1 commit into from
Mar 6, 2023

Conversation

LKreutzer
Copy link
Contributor

@LKreutzer LKreutzer commented Mar 6, 2023

Summary

  • Skip the following tests to unblock CI (see e.g. this test run):
app/views/events/__tests__/EventsTableTest.tsx
app/views/equipment/__tests__/GatewayLogsTest.tsx
app/components/cwf/__tests__/CWFGateways-test.tsx
app/views/equipment/__tests__/FEGGatewayDetailStatusTest.tsx

Test Plan

  • Run yarn run test locally:
Test Suites: 4 skipped, 53 passed, 53 of 57 total
Tests:       4 skipped, 351 passed, 355 total
Snapshots:   0 total
Time:        25.129 s
Ran all test suites in 2 projects.
Done in 25.77s.
Test Suites: 4 skipped, 53 passed, 53 of 57 total
Tests:       4 skipped, 351 passed, 355 total
Snapshots:   0 total
Time:        187.614 s
Ran all test suites in 2 projects.
Done in 189.13s.

Additional Information

  • This change is backwards-breaking

Signed-off-by: Lars Kreutzer <lars.kreutzer@tngtech.com>
@LKreutzer LKreutzer added the component: nms NMS-related issue label Mar 6, 2023
@LKreutzer LKreutzer self-assigned this Mar 6, 2023
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines. label Mar 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2023

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2023

DP Lint & Test

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit ded74fc.

@LKreutzer LKreutzer requested a review from maxhbr March 6, 2023 08:38
@LKreutzer LKreutzer marked this pull request as ready for review March 6, 2023 08:38
@LKreutzer LKreutzer requested a review from a team as a code owner March 6, 2023 08:38
Copy link
Member

@maxhbr maxhbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LKreutzer LKreutzer merged commit 6bf1f7e into magma:master Mar 6, 2023
lucasgonze pushed a commit to lucasgonze/magma that referenced this pull request Feb 29, 2024
Signed-off-by: Lars Kreutzer <lars.kreutzer@tngtech.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: nms NMS-related issue size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants