fix(nms): nginx ssl issue #15215

prabinakpattnaik · 2023-06-15T14:29:35Z

Below error is observed when creating orc8r pods:
2023/06/15 13:34:36 [emerg] 1#1: unknown directive "ssl" in /etc/nginx/conf.d/nginx_proxy_ssl.conf:3
nginx: [emerg] unknown directive "ssl" in /etc/nginx/conf.d/nginx_proxy_ssl.conf:3

orc8r nms-nginx-proxy-7454448447-xzc8l 0/1 CrashLoopBackOff 7 (119s ago) 16m

github-actions · 2023-06-15T14:29:53Z

Thanks for opening a PR! 💯

A couple initial guidelines

All commits must be signed off. This is enforced by PR DCO check.
All PR titles must follow the semantic commits format. This is enforced by PR Check Title Or Commit Message.

Howto

Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
Checks. All required CI checks must pass before merge.
Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

Contributing Conventions for norms around contributed code

If this is your first Magma PR, also consider reading

Developer Onboarding for onboarding as a new Magma developer
Development Workflow for guidance on your first PR
CI Checks for points of contact for failing or flaky CI checks
Code Review Process for information on requesting reviews and contacting maintainers

github-actions · 2023-06-15T14:30:36Z

DP Lint & Test

0 tests 0 ✔️ 0s ⏱️
0 suites 0 💤
0 files 0 ❌

Results for commit b521d2c.

♻️ This comment has been updated with latest results.

maxhbr

Code changes look good.

github-actions · 2023-06-15T14:45:33Z

NMS Lint & Test

0 tests 0 ✔️ 0s ⏱️
0 suites 0 💤
0 files 0 ❌

Results for commit b521d2c.

♻️ This comment has been updated with latest results.

Signed-off-by: prabina pattnaik <prabinak@wavelabs.ai>

maxhbr · 2023-06-16T09:13:33Z

CI is red, due to out of disk space in a build:

and nms yarn test is red: https://github.com/magma/magma/actions/runs/5280377687/jobs/9558018580?pr=15215

prabinakpattnaik · 2023-06-16T09:20:16Z

@maxhbr , any idea why "nms yarn test" is failed. Is it lint error or test case failed error.

maxhbr · 2023-06-16T09:21:13Z

you can look in the log and see the test summary:

Summary of all failing tests
FAIL app/views/traffic/__tests__/TrafficOverviewTest.tsx (8.891 s)
  ● <TrafficDashboard APNs/> › renders

    TypeError: Cannot redefine property: location

      319 |
      320 |   beforeEach((): void => {
    > 321 |     window.location = {
          |     ^
      322 |       pathname: '/nms/test/traffic/apn',
      323 |     } as Location;
      324 |

      at Object.<anonymous> (app/views/traffic/__tests__/TrafficOverviewTest.tsx:321:5)

  ● <TrafficDashboard APNs/> › renders

    TypeError: Cannot redefine property: location

      340 |
      341 |   afterEach((): void => {
    > 342 |     window.location = location;
          |     ^
      343 |   });
      344 |
      345 |   const Wrapper = () => (

      at Object.<anonymous> (app/views/traffic/__tests__/TrafficOverviewTest.tsx:342:5)

  ● <TrafficDashboard APNs/> › shows prompt when remove apn is clicked

    TypeError: Cannot redefine property: location

      319 |
      320 |   beforeEach((): void => {
    > 321 |     window.location = {
          |     ^
      322 |       pathname: '/nms/test/traffic/apn',
      323 |     } as Location;
      324 |

      at Object.<anonymous> (app/views/traffic/__tests__/TrafficOverviewTest.tsx:321:5)

  ● <TrafficDashboard APNs/> › shows prompt when remove apn is clicked

    TypeError: Cannot redefine property: location

      340 |
      341 |   afterEach((): void => {
    > 342 |     window.location = location;
          |     ^
      343 |   });
      344 |
      345 |   const Wrapper = () => (

      at Object.<anonymous> (app/views/traffic/__tests__/TrafficOverviewTest.tsx:342:5)


Test Suites: 1 failed, 4 skipped, 52 passed, 53 of 57 total
Tests:       2 failed, 4 skipped, 349 passed, 355 total

there are test failures

prabinakpattnaik · 2023-06-16T09:26:03Z

Yes, I have seen yesterday on that logs but could not get the clue for whether these errors are link with changes or existing error.

maxhbr · 2023-06-16T09:35:02Z

it seems to be a general issue that needs to be resolved. Also other PRs have the same issues in the log https://github.com/magma/magma/actions/runs/5247558970/jobs/9477884882?pr=15211

prabinakpattnaik · 2023-06-16T11:44:49Z

@maxhbr , can we do force merge the changes as both CI checks are failing because of one is know issue and another is disk space issue.

maxhbr · 2023-06-16T11:48:09Z

see https://magmacore.slack.com/archives/C01Q1T14YJ2/p1686916038724709?thread_ts=1686905954.161159&cid=C01Q1T14YJ2, since there is no process for force merges.

Signed-off-by: prabina pattnaik <prabinak@wavelabs.ai>

maxhbr · 2023-06-16T13:12:04Z

nms/app/views/traffic/__tests__/TrafficOverviewTest.tsx

@@ -318,6 +318,8 @@ describe('<TrafficDashboard APNs/>', () => {
  const networkId = 'test';

  beforeEach((): void => {
+    // @ts-ignore
+    delete window.location;


if you start working on fixing CI runs, force merges are no longer an option. Would also fit to be put into its own PR?

Hey, can you remove that commit again, so that the impact of a potential force merge is smaller? Also: the commit message is not very helpful.

ping: can someone drop that commit, so that we can move forward?

lucasgonze · 2023-06-16T13:35:09Z

Seems like the underlying failure is meaningful:

Warning: A component is changing a controlled input to be uncontrolled. This is likely caused by the value changing from a defined to undefined, which should not happen. Decide between using a controlled or uncontrolled input element for the lifetime of the component. More info: https://reactjs.org/link/controlled-components

However, the code in this commit doesn't do anything in NMS, so the problem must be a prior commit. Do you agree?

maxhbr · 2023-06-16T13:46:38Z

see: #15215 (comment)

the NMS error already appeared in other CI runs before this change. So, for NMS the answer is probably yes.

prabinakpattnaik · 2023-06-19T08:34:04Z

I have raised new PR for this issue fix.
15217.

maxhbr · 2023-06-19T08:35:29Z

Good, that change can be discussed there and the decision whether it is appropriate does not block this PR.

maxhbr · 2023-06-19T08:52:21Z

@prabinakpattnaik : you still need to drop 34da9f8 from this PR to unblock it.

prabinakpattnaik · 2023-06-19T08:53:53Z

@maxhbr , I am doing now.

Signed-off-by: prabina pattnaik <prabinak@wavelabs.ai>

maxhbr · 2023-06-19T09:07:46Z

now it does the change, and reverts it again. But after squashing that should be hidden.

Now we just need to find someone that is able to force-merge. This was made harder with some of the recent policy changes (ping @lucasgonze). see also: https://magmacore.slack.com/archives/C01Q1T14YJ2/p1687165644395929?thread_ts=1686905954.161159&cid=C01Q1T14YJ2

Force merge with go from Lucas Gonze: https://magmacore.slack.com/archives/C01Q1T14YJ2/p1687184855726759 * fix(nms): nginx ssl issue Signed-off-by: prabina pattnaik <prabinak@wavelabs.ai> * fix(nms): nginx ssl issue Signed-off-by: prabina pattnaik <prabinak@wavelabs.ai> * fix(nms): nginx ssl issue Signed-off-by: prabina pattnaik <prabinak@wavelabs.ai> --------- Signed-off-by: prabina pattnaik <prabinak@wavelabs.ai>

prabinakpattnaik requested a review from a team as a code owner June 15, 2023 14:29

prabinakpattnaik requested a review from HannaFar June 15, 2023 14:29

pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines. label Jun 15, 2023

github-actions bot added the component: nms NMS-related issue label Jun 15, 2023

maxhbr approved these changes Jun 15, 2023

View reviewed changes

fix(nms): nginx ssl issue

2874ad9

Signed-off-by: prabina pattnaik <prabinak@wavelabs.ai>

prabinakpattnaik force-pushed the nginx_ssl_issue branch from 9a45078 to 2874ad9 Compare June 15, 2023 14:57

maxhbr mentioned this pull request Jun 16, 2023

fix(ci): ci dashboard issue #15214

Merged

1 task

fix(nms): nginx ssl issue

34da9f8

Signed-off-by: prabina pattnaik <prabinak@wavelabs.ai>

maxhbr reviewed Jun 16, 2023

View reviewed changes

fix(nms): nginx ssl issue

b521d2c

Signed-off-by: prabina pattnaik <prabinak@wavelabs.ai>

maxhbr merged commit 00fde73 into magma:master Jun 19, 2023
89 of 91 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(nms): nginx ssl issue #15215

fix(nms): nginx ssl issue #15215

prabinakpattnaik commented Jun 15, 2023

github-actions bot commented Jun 15, 2023

github-actions bot commented Jun 15, 2023 •

edited

maxhbr left a comment

github-actions bot commented Jun 15, 2023 •

edited

maxhbr commented Jun 16, 2023

prabinakpattnaik commented Jun 16, 2023

maxhbr commented Jun 16, 2023

prabinakpattnaik commented Jun 16, 2023

maxhbr commented Jun 16, 2023

prabinakpattnaik commented Jun 16, 2023

maxhbr commented Jun 16, 2023

maxhbr Jun 16, 2023

maxhbr Jun 16, 2023

panyogesh Jun 16, 2023

maxhbr Jun 19, 2023

lucasgonze commented Jun 16, 2023

maxhbr commented Jun 16, 2023 •

edited

prabinakpattnaik commented Jun 19, 2023

maxhbr commented Jun 19, 2023

maxhbr commented Jun 19, 2023

prabinakpattnaik commented Jun 19, 2023

maxhbr commented Jun 19, 2023

fix(nms): nginx ssl issue #15215

fix(nms): nginx ssl issue #15215

Conversation

prabinakpattnaik commented Jun 15, 2023

github-actions bot commented Jun 15, 2023

Howto

More info

github-actions bot commented Jun 15, 2023 • edited

DP Lint & Test

maxhbr left a comment

Choose a reason for hiding this comment

github-actions bot commented Jun 15, 2023 • edited

NMS Lint & Test

maxhbr commented Jun 16, 2023

prabinakpattnaik commented Jun 16, 2023

maxhbr commented Jun 16, 2023

prabinakpattnaik commented Jun 16, 2023

maxhbr commented Jun 16, 2023

prabinakpattnaik commented Jun 16, 2023

maxhbr commented Jun 16, 2023

maxhbr Jun 16, 2023

Choose a reason for hiding this comment

maxhbr Jun 16, 2023

Choose a reason for hiding this comment

panyogesh Jun 16, 2023

Choose a reason for hiding this comment

maxhbr Jun 19, 2023

Choose a reason for hiding this comment

lucasgonze commented Jun 16, 2023

maxhbr commented Jun 16, 2023 • edited

prabinakpattnaik commented Jun 19, 2023

maxhbr commented Jun 19, 2023

maxhbr commented Jun 19, 2023

prabinakpattnaik commented Jun 19, 2023

maxhbr commented Jun 19, 2023

github-actions bot commented Jun 15, 2023 •

edited

github-actions bot commented Jun 15, 2023 •

edited

maxhbr commented Jun 16, 2023 •

edited