Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): Update the MacOS runner image #15354

Merged
merged 2 commits into from
Feb 13, 2024
Merged

fix(ci): Update the MacOS runner image #15354

merged 2 commits into from
Feb 13, 2024

Conversation

akhilamoyila9
Copy link
Contributor

Changes:

  1. Updated the MacOS runner to large MacOS runner , as it's supporting the nested Virtualization

Summary

Due to inconsistency of MacOS 12 runner images ,
we have modified the Workflows to use macos-12-large runner images

Test Plan

Attaching the issue links for reference
issue-8642
Gurumeditation issue

Additional Information

  • This change is backwards-breaking

Security Considerations

@akhilamoyila9
fix(ci): Updating the macos runner image
e2523d9 
changes:
 1) Updated the MacOS runner to large MacOS runner , as it was supporting the nested Virtualization

Signed-off-by: akhilamoyila9 <akhila.moyila@wavelabs.ai>
@akhilamoyila9 akhilamoyila9 requested a review from a team as a code owner December 12, 2023 07:32
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines. label Dec 12, 2023
@github-actions GitHub Actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: ci All updates on CI (Jenkins/CircleCi/Github Action) label Dec 12, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 12, 2023 •
edited
Loading

DP Lint & Test

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit ce5d4fc.

♻️ This comment has been updated with latest results.

panyogesh
panyogesh approved these changes Feb 13, 2024
View reviewed changes
Copy link
Contributor

@panyogesh panyogesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tapasmishra
tapasmishra approved these changes Feb 13, 2024
View reviewed changes
Copy link

@tapasmishra tapasmishra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@panyogesh panyogesh merged commit 0b6303e into magma:master Feb 13, 2024
102 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tapasmishra tapasmishra tapasmishra approved these changes

@rdefosse rdefosse rdefosse approved these changes

@panyogesh panyogesh panyogesh approved these changes

@jordanvrtanoski jordanvrtanoski Awaiting requested review from jordanvrtanoski jordanvrtanoski is a code owner automatically assigned from magma/approvers-infra

Assignees
No one assigned
Labels
component: ci All updates on CI (Jenkins/CircleCi/Github Action) size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@akhilamoyila9 @tapasmishra @rdefosse @panyogesh