Fixes for timer expiry for stateless mme #1957
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed the memory leaks for mme_app timers
…enb_s1ap_id_same_ue.py 2. With this fix basic attach-detach test case is passing on enabling stateles MME
…fferent_enb_s1ap_id_same_ue.py" This reverts commit f6658a0.
|
Can one of the admins verify this patch? |
|
during commit, have you included "-s" option for sign off? check out https://github.com/magma/community/blob/main/CONTRIBUTING.md |
|
In the summary, could you put more context, e.g., why the change is done in addition to what the change is? |
ulaskozat
requested changes
Jul 27, 2020
Signed-off-by: rashmi <rashmi.sarwad@radisys.com>
rsarwad
force-pushed
the
rsarwad_fixes_for_timer_expiry_for_stateless
branch
from
94b2940
to
de026d0
Compare
…_timer_expiry_for_stateless
…_timer_expiry_for_stateless Signed-off-by: rashmi <rashmi.sarwad@radisys.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Issue #1 : While testing the Implicit detach timer with MME restart observed that UE contexts were not updated to redis DB. Because on timer expiry, imsi64 was neither received from timer module nor got from the handler function. So imsi64 was set to "INVALID_IMSI64". Only for valid imsi64 values, UE contexts are updated to DB.
Approach followed to address above issue:
Issue #2: The prototype of timer start function is int timer_setup(
uint32_t interval_sec, uint32_t interval_us, task_id_t task_id,
int32_t instance, timer_type_t type, void* timer_arg, size_t arg_size,
long* timer_id)
Which expects seconds and micro-seconds to be of datatype uint32_t, but for most timers while calling timer_setup, seconds and micro-seconds were defined as long
Test Plan:
Executed s1ap tester sanity test suite