Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NMS] Minor fixes in Gateway overview page #2232

Merged
merged 1 commit into from Aug 7, 2020

Conversation

karthiksubraveti
Copy link
Contributor

@karthiksubraveti karthiksubraveti commented Aug 7, 2020

Signed-off-by: Karthik Subraveti karthikshyam@gmail.com

Summary

  • Fix all overview pages to link to detail screens
  • Remove deactivate and reboot actions

Test Plan

yarn test passes fine
overview

Additional Information

  • This change is backwards-breaking

@karthiksubraveti karthiksubraveti added the component: nms NMS-related issue label Aug 7, 2020
@karthiksubraveti karthiksubraveti force-pushed the nms.cleanup.0 branch 2 times, most recently from 5723cec to cf00d27 Compare August 7, 2020 05:21
@karthiksubraveti karthiksubraveti changed the title [NMS] Make gateway ID a link in Gateway overview page [NMS] Minor fixes in Gateway overview page Aug 7, 2020
Signed-off-by: Karthik Subraveti <karthikshyam@gmail.com>
@karthiksubraveti karthiksubraveti merged commit d8275d2 into magma:master Aug 7, 2020
ardzoht added a commit to ardzoht/magma that referenced this pull request Aug 10, 2020
* 'master' of github.com:magma/magma: (31 commits)
  [AGW]: uplink_br0: configure using DHCP (magma#2218)
  Remove axios as a package dependency from magmalte. (magma#2246)
  [pipelined] Add conntrack pipelined controller (magma#2191)
  Bump dotenv from 6.2.0 to 8.2.0 in /nms/app (magma#2247)
  Bump nodemon from 1.19.4 to 2.0.4 in /nms/app (magma#2248)
  Bump @testing-library/react from 9.5.0 to 10.4.8 in /nms/app (magma#2249)
  [orc8r][cwf]LI swagger API update (magma#2170)
  [AGW] MME: add retry for mobility ip block read API. (magma#2233)
  Refactored CardTitleRow into single component (magma#2224)
  Add policy JSON editor (magma#2182)
  [lte][agw] Updating _get_enb_label_from_request to get IP from peername request (magma#2244)
  Make gateway ID a link in Gateway overview page (magma#2232)
  Fix metric label used for querying (magma#2241)
  Hide gateway status in JSON editor (magma#2223)
  Bump postcss-flexbugs-fixes from 3.3.1 to 4.2.1 in /nms/app (magma#2236)
  Bump regenerator-runtime from 0.13.5 to 0.13.7 in /nms/app (magma#2234)
  Bump @testing-library/react-hooks from 3.3.0 to 3.4.1 in /nms/app (magma#2235)
  Clean up Session Recycling Logic (magma#2149)
  Migrate CreateSessionRequest to use bundled fields (magma#2166)
  orc8r-values.tpl YAML template fix (magma#2228)
  ...
@karthiksubraveti karthiksubraveti deleted the nms.cleanup.0 branch August 26, 2020 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: nms NMS-related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants