New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AGW] pipelineD: configure SGi management ip address. #2510
Conversation
796dc84
to
a4489aa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly nits
lte/gateway/python/magma/pipelined/tests/pipelined_test_util.py
Outdated
Show resolved
Hide resolved
lte/gateway/python/magma/pipelined/tests/pipelined_test_util.py
Outdated
Show resolved
Hide resolved
a4489aa
to
e3a7ccc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
lte/gateway/python/magma/pipelined/tests/pipelined_test_util.py
Outdated
Show resolved
Hide resolved
e3a7ccc
to
4273242
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one thing is fishy
lte/gateway/python/magma/pipelined/tests/pipelined_test_util.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Pravin B Shelar <pbshelar@fb.com>
4273242
to
ebd98b0
Compare
Summary
This allows operator to configure static IP address on
SGi for management traffic.
Only single IP is allowed.
Signed-off-by: Pravin B Shelar pbshelar@fb.com
Test Plan
Additional Information