Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AGW] pipelineD: configure SGi management ip address. #2510

Merged
merged 1 commit into from Aug 28, 2020

Conversation

pshelar
Copy link
Contributor

@pshelar pshelar commented Aug 27, 2020

Summary

This allows operator to configure static IP address on
SGi for management traffic.
Only single IP is allowed.

Signed-off-by: Pravin B Shelar pbshelar@fb.com

Test Plan

Additional Information

  • This change is backwards-breaking

Copy link
Contributor

@koolzz koolzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly nits

lte/gateway/python/magma/pipelined/main.py Outdated Show resolved Hide resolved
lte/gateway/python/magma/pipelined/app/uplink_bridge.py Outdated Show resolved Hide resolved
lte/gateway/python/magma/pipelined/app/uplink_bridge.py Outdated Show resolved Hide resolved
Copy link
Contributor

@koolzz koolzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pshelar pshelar added this to In progress in Magma APN Resource Configuration Support via automation Aug 28, 2020
@pshelar pshelar linked an issue Aug 28, 2020 that may be closed by this pull request
Copy link
Contributor

@xjtian xjtian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one thing is fishy

Signed-off-by: Pravin B Shelar <pbshelar@fb.com>
@pshelar pshelar merged commit 98b80d9 into magma:master Aug 28, 2020
Magma APN Resource Configuration Support automation moved this from In progress to Done Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

AGW: add static configuration for SGi interface.
3 participants