[NMS] Disable "create network" in network sidebar for non LTE networks. #2547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This didn't work even prior to Magma NMS rewrite. The redirect to /admin/networks/new doesn't seem to work. It again gets redirected to /nms. User will still be able to add a network from administrative tools. Signed-off-by: Karthik Subraveti <karthikshyam@gmail.com>
karthiksubraveti
requested review from
andreilee,
Scott8440 and
xjtian
as code owners
xjtian
approved these changes
Aug 31, 2020
r-i-g
pushed a commit
to r-i-g/magma
that referenced
this pull request
Sep 2, 2020
…gma#2547) This didn't work even prior to Magma NMS rewrite. The redirect to /admin/networks/new doesn't seem to work. It again gets redirected to /nms. User will still be able to add a network from administrative tools. Signed-off-by: Karthik Subraveti <karthikshyam@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Karthik Subraveti karthikshyam@gmail.com
Summary
This didn't work even prior to Magma NMS rewrite. The redirect to
/admin/networks/new doesn't seem to work. It again gets redirected to
/nms. User will still be able to add a network from administrative tools.
Test Plan
Additional Information