Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lte][agw] Fix bug in deletion of dedicated bearer #2605

Merged
merged 1 commit into from Sep 3, 2020

Conversation

ulaskozat
Copy link
Contributor

@ulaskozat ulaskozat commented Sep 3, 2020

Signed-off-by: Ulas Kozat kozat@fb.com

Summary

The exact match for DL flow rules were not included during the network initiated deactivation of dedicated bearers. This was resulting in the deletion of the default bearer rules.

  • Added exact DL flow match rules used for the bearer.
  • Refactored the code for better code reuse and readability.

Test Plan

Integ tests and new tests included in #PR2588.
Testbed experiments.

Signed-off-by: Ulas Kozat <kozat@fb.com>
eps_bearer_ctxt_p->s_gw_teid_S1u_S12_S4_up,
eps_bearer_ctxt_p->enb_teid_S1u, &dlflow);
if (rc < 0) {
OAILOG_ERROR_UE(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this formatted?

@ulaskozat ulaskozat merged commit fcb73ad into magma:master Sep 3, 2020
@ulaskozat ulaskozat deleted the mme_fix_deletebearer branch September 3, 2020 17:27
ulaskozat added a commit to ulaskozat/magma that referenced this pull request Sep 16, 2020
Signed-off-by: Ulas Kozat <kozat@fb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants