Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[nms] Update eNodeb docs and metrics to use datapath gtp stats #3534

Merged
merged 8 commits into from
Nov 2, 2020
Merged

[nms] Update eNodeb docs and metrics to use datapath gtp stats #3534

merged 8 commits into from
Nov 2, 2020

Conversation

ardzoht
Copy link
Contributor

@ardzoht ardzoht commented Oct 29, 2020 •
edited

Summary

  • This diff updates eNB metrics on NMS to use gtp_port_user_plane_bytes metrics collected by pipelined service that are retrieved for all eNB setups.
  • Adds enb IP address to be reported on eNB state, so metrics can be filtered by this parameter for single eNBs
  • Updates docs/enodeb.md with registration steps for unmanaged eNBs

Test Plan

  • Testing using eNB, local Orc8r and NMS to validate metrics are updated correctly and shown on eNB NMS views
  • Bringing up local docusaurus container to validate changes on docs

image

image

Additional Information

  • This change is backwards-breaking

@ardzoht
Using gtp_port_user_plane_dl_bytes, gtp_port_user_plane_ul_bytes for …
3d2c82b 
…enb data usage metrics

Signed-off-by: Alejandro Rodriguez <alexrod@fb.com>
@ardzoht ardzoht added the apply-v1.3 Needs to be applied to v1.3 release branch as well label Oct 29, 2020
@ardzoht ardzoht added this to In progress in Unmanaged eNBs Support via automation Oct 29, 2020
@ardzoht
Adding enb_ip_address to be reported on enb state
728656f 
Signed-off-by: Alejandro Rodriguez <alexrod@fb.com>
@ardzoht
Adding enb_ip_address to be reported on enb state
b2a6d0a 
Signed-off-by: Alejandro Rodriguez <alexrod@fb.com>
@ardzoht
Including APIBindings file change
cfebaa6 
Signed-off-by: Alejandro Rodriguez <alexrod@fb.com>
@ardzoht
Updating enodebd.md with steps to register unmanaged eNBs
5c4dd94 
Signed-off-by: Alejandro Rodriguez <alexrod@fb.com>
@ardzoht
Updated eNodeB configuration docs with unmanaged registration steps
345f9b8 
Signed-off-by: Alejandro Rodriguez <alexrod@fb.com>
@ardzoht ardzoht changed the title [nms] Update eNodeb metrics to use datapath gtp stats [nms] Update eNodeb docs and metrics to use datapath gtp stats Oct 29, 2020
@ardzoht ardzoht added this to the Sprint: Oct 12 - Nov 1, 2020 milestone Oct 30, 2020
karthiksubraveti
karthiksubraveti approved these changes Oct 30, 2020
View reviewed changes
Copy link
Contributor

@karthiksubraveti karthiksubraveti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

nms/app/packages/magmalte/app/views/equipment/GatewayDetailEnodebs.js Outdated Show resolved Hide resolved
nms/app/packages/magmalte/app/views/equipment/GatewayDetailEnodebs.js Outdated Show resolved Hide resolved
@ardzoht
Updates on comments
76a208e 
Signed-off-by: Alejandro Rodriguez <alexrod@fb.com>
hcgatewood
hcgatewood approved these changes Nov 2, 2020
View reviewed changes
Copy link
Contributor

@hcgatewood hcgatewood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cloud changes lgtm

lte/cloud/go/services/lte/obsidian/models/swagger.v1.yml Outdated Show resolved Hide resolved
lte/cloud/go/services/lte/obsidian/models/swagger.v1.yml Show resolved Hide resolved
@ardzoht
Using ipv4 format for ip_address
10146f0 
Signed-off-by: Alejandro Rodriguez <alexrod@fb.com>
@ardzoht ardzoht merged commit b5483c1 into magma:master Nov 2, 2020
Unmanaged eNBs Support automation moved this from In progress to Done Nov 2, 2020
xjtian pushed a commit that referenced this pull request Nov 9, 2020
@ardzoht @xjtian
[nms] Update eNodeb docs and metrics to use datapath gtp stats (#3534)
ecde091 
* Using gtp_port_user_plane_dl_bytes, gtp_port_user_plane_ul_bytes for enb data usage metrics

Signed-off-by: Alejandro Rodriguez <alexrod@fb.com>

* Adding enb_ip_address to be reported on enb state

Signed-off-by: Alejandro Rodriguez <alexrod@fb.com>

* Adding enb_ip_address to be reported on enb state

Signed-off-by: Alejandro Rodriguez <alexrod@fb.com>

* Including APIBindings file change

Signed-off-by: Alejandro Rodriguez <alexrod@fb.com>

* Updating enodebd.md with steps to register unmanaged eNBs

Signed-off-by: Alejandro Rodriguez <alexrod@fb.com>

* Updated eNodeB configuration docs with unmanaged registration steps

Signed-off-by: Alejandro Rodriguez <alexrod@fb.com>

* Updates on comments

Signed-off-by: Alejandro Rodriguez <alexrod@fb.com>

* Using ipv4 format for ip_address

Signed-off-by: Alejandro Rodriguez <alexrod@fb.com>
@xjtian xjtian added the backported-v1.3 Has been backported to v1.3 release branch label Nov 9, 2020
ardzoht added a commit to ardzoht/magma that referenced this pull request Mar 4, 2021
@ardzoht
[nms] Update eNodeb docs and metrics to use datapath gtp stats (magma…
0739439 
…#3534)

* Using gtp_port_user_plane_dl_bytes, gtp_port_user_plane_ul_bytes for enb data usage metrics

Signed-off-by: Alejandro Rodriguez <alexrod@fb.com>

* Adding enb_ip_address to be reported on enb state

Signed-off-by: Alejandro Rodriguez <alexrod@fb.com>

* Adding enb_ip_address to be reported on enb state

Signed-off-by: Alejandro Rodriguez <alexrod@fb.com>

* Including APIBindings file change

Signed-off-by: Alejandro Rodriguez <alexrod@fb.com>

* Updating enodebd.md with steps to register unmanaged eNBs

Signed-off-by: Alejandro Rodriguez <alexrod@fb.com>

* Updated eNodeB configuration docs with unmanaged registration steps

Signed-off-by: Alejandro Rodriguez <alexrod@fb.com>

* Updates on comments

Signed-off-by: Alejandro Rodriguez <alexrod@fb.com>

* Using ipv4 format for ip_address

Signed-off-by: Alejandro Rodriguez <alexrod@fb.com>
m-trojanowski pushed a commit to openEPC/magma that referenced this pull request Oct 20, 2021
@ardzoht @xjtian
[nms] Update eNodeb docs and metrics to use datapath gtp stats (magma…
87bfeaa 
…#3534)

* Using gtp_port_user_plane_dl_bytes, gtp_port_user_plane_ul_bytes for enb data usage metrics

Signed-off-by: Alejandro Rodriguez <alexrod@fb.com>

* Adding enb_ip_address to be reported on enb state

Signed-off-by: Alejandro Rodriguez <alexrod@fb.com>

* Adding enb_ip_address to be reported on enb state

Signed-off-by: Alejandro Rodriguez <alexrod@fb.com>

* Including APIBindings file change

Signed-off-by: Alejandro Rodriguez <alexrod@fb.com>

* Updating enodebd.md with steps to register unmanaged eNBs

Signed-off-by: Alejandro Rodriguez <alexrod@fb.com>

* Updated eNodeB configuration docs with unmanaged registration steps

Signed-off-by: Alejandro Rodriguez <alexrod@fb.com>

* Updates on comments

Signed-off-by: Alejandro Rodriguez <alexrod@fb.com>

* Using ipv4 format for ip_address

Signed-off-by: Alejandro Rodriguez <alexrod@fb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreilee andreilee andreilee approved these changes

@xjtian xjtian xjtian approved these changes

@hcgatewood hcgatewood hcgatewood approved these changes

@karthiksubraveti karthiksubraveti karthiksubraveti approved these changes

@Scott8440 Scott8440 Awaiting requested review from Scott8440

@mpgermano mpgermano Awaiting requested review from mpgermano

Assignees
No one assigned
Labels
apply-v1.3 Needs to be applied to v1.3 release branch as well backported-v1.3 Has been backported to v1.3 release branch
Projects
No open projects
Unmanaged eNBs Support
  
Done
Milestone
Sprint: Oct 12 - Nov 1, 2020
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ardzoht @andreilee @xjtian @hcgatewood @karthiksubraveti