Sessiond module MVC phase converged core changes

[gurrapualt]

lte_integ_PR3898.log
Sessiond module MVC phase converged core changes

service reqest handling from AMF, UE moves to active

 --> Default QOS Changes support
 --> Default Uplink/DownLink rules adding to all sessions
 --> Multiple sessions support with PDUID instead of APN
 --> Paging request from UPF GRPC handling
 --> Upf thread handlers and Server messages support
 --> Periodic Messages Handling
 --> UPF Node message Handling
 --> GnodeB and UPF TEID and ipadress handling changes
 --> Fixing UT errors with newly added pipeline handlers
 --> Handling  Amf Notifications GRPC handling (inclduing Idle mode)
 --> All the code cleanup and fixes
 --> Review comments addressing
 --> All required MVC changes

!-- Enumerate changes you made and why you made them -->

Test Plan

Attached sessiond logs.
v1.txt

Additional Information

• This change is backwards-breaking

Attached sessind unit test logs
Inact-act-log.txt
[lte_integ_3898] attached.

Attached latest lte integ tests
All LTE test results are splitted on below 4 files
he.log
7tests.txt
traffic.log
integ.log

[uri200]

For future, can you use a meaningful name for the branch. This way we can identify it in the future.

[gurrapualt]

Hi Oriol/Marie, I was using one branch all my check in's. Do we have to create separate branch for every check-in request ? Is it a must procdure to follow ? Regards Venu From: "Oriol Batalla" <notifications@github.com> To: "magma/magma" <magma@noreply.github.com> Cc: "gurrapualt" <venukumar.g@altencalsoftlabs.com>, "Assign" <assign@noreply.github.com> Sent: Tuesday, December 8, 2020 9:40:27 PM Subject: Re: [magma/magma] Venu (#3898) For future, can you use a meaningful name for the branch. This way we can identify it in the future. — You are receiving this because you were assigned. Reply to this email directly, [ #3898 (comment) | view it on GitHub ] , or [ https://github.com/notifications/unsubscribe-auth/APP6N6YZO6PILWB5HRMOKALSTZFXHANCNFSM4UNOG23Q | unsubscribe ] .

[gurrapualt]

For future, can you use a meaningful name for the branch. This way we can identify it in the future.

sure.

[uri200]

the insync test is failing due to your changes on pipelined.proto
You need to rebase first and then do

magma/orc8r/cloud/docker ./build.py -g

and then include the lte/cloud/go/protos/pipelined.pb.go

[gurrapualt]

Somehow I missed, just now pushed again with updated one. From: Oriol Batalla [mailto:notifications@github.com] Sent: 09 December 2020 20:12 To: magma/magma Cc: gurrapualt; Assign Subject: Re: [magma/magma] Venu (#3898) the insync test is failing due to your changes on pipelined.proto You need to rebase first and then do magma/orc8r/cloud/docker ./build.py -g and then include the lte/cloud/go/protos/pipelined.pb.go — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#3898 (comment)> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/APP6N65BDUBYD6SYZA3HZ7LST6EDVANCNFSM4UNOG23Q> . <https://github.com/notifications/beacon/APP6N62S6DOIZR5X7TMVJCDST6EDVA5CNFSM4UNOG232YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOFQ3TJ3A.gif>

[themarwhal]

Thanks for addressing the comments + build failures. Last thing, pls take a look at why SessionD is crashing in CWAG integration test. From the attached sessiond logs I see

2021-03-28T09:17:18.134875000Z Aborted (core dumped)
2021-03-28T09:17:19.508845000Z kernel.core_pattern = /var/opt/magma/cores/core.%e.%t
2021-03-28T09:17:19.606537000Z [/magma/orc8r/gateway/c/common/config/ServiceConfigLoader.cpp:33] Override file not found for service sessiond
2021-03-28T09:17:19.607031000Z I0328 09:17:19.606649     9 magma_logging.h:33] Setting verbosity to 4
2021-03-28T09:17:19.607503000Z terminate called after throwing an instance of 'YAML::TypedBadConversion<long>'
2021-03-28T09:17:19.610686000Z   what():  yaml-cpp: error at line 0, column 0: bad conversion
2021-03-28T09:17:19.618427000Z Aborted (core dumped)

This probably suggests something in the config loading part maybe? Please make sure to check that the config tag exists before loading to not cause a crash.

Probably this one: session_max_rtx_count = config["session_rtx_count"].as<long>();

[gurrapualt]

Working on, this is only thing pending. Tomorrow I’ll run locally and then figure out. Most likely – newly added config parameters are no part of script running setup configuration. Anyway – tomorrow I ll update the results once I get CWAG/LTE results. Regards Venu From: Marie ***@***.*** Sent: 28 March 2021 17:34 To: magma/magma Cc: gurrapualt; Mention Subject: Re: [magma/magma] Sessiond module MVC phase converged core changes (#3898) Thanks for addressing the comments + build failures. Last thing, pls take a look at why SessionD is crashing in CWAG integration test. From the attached sessiond logs I see 2021-03-28T09:17:18.134875000Z Aborted (core dumped) 2021-03-28T09:17:19.508845000Z kernel.core_pattern = /var/opt/magma/cores/core.%e.%t 2021-03-28T09:17:19.606537000Z [/magma/orc8r/gateway/c/common/config/ServiceConfigLoader.cpp:33] Override file not found for service sessiond 2021-03-28T09:17:19.607031000Z I0328 09:17:19.606649 9 magma_logging.h:33] Setting verbosity to 4 2021-03-28T09:17:19.607503000Z terminate called after throwing an instance of 'YAML::TypedBadConversion<long>' 2021-03-28T09:17:19.610686000Z what(): yaml-cpp: error at line 0, column 0: bad conversion 2021-03-28T09:17:19.618427000Z Aborted (core dumped) This probably suggests something in the config loading part maybe? Please make sure to check that the config tag exists before loading to not cause a crash. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3898 (comment)> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/APP6N62AYJXLGXT73OCLRH3TF4LJJANCNFSM4UNOG23Q> . <https://github.com/notifications/beacon/APP6N62NEB2UAWU27CLBEB3TF4LJJA5CNFSM4UNOG232YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOGA3KI5A.gif>

[ulaskozat]

Approving with the expectation that ip address and tunnel ID types (with AMF) be fixed in a later PR.

[themarwhal]

Filed an issue to increase unit test coverage on SMF files: #5825

[ardzoht]

lgtm, but please take a look at minor comments left

[gurrapualt]

Approving with the expectation that ip address and tunnel ID types (with AMF) be fixed in a later PR.

sure .. already raised PR.