Added testcase to validate 3485 timer for both default and dedicated bearer #3970

rsarwad · 2020-12-09T15:45:32Z

[AGW]: Added testcase to validate 3485 timer for both default and dedicated bearer while mme restarts

Summary

Added testcase to validate 3485 timer for both default and dedicated bearer while mme restarts

Test Plan

Executed s1ap sanity test suite
##Additional information
The first message, Activate Default/Dedicated Eps Bearer Context Request message is sent in E-Rab-Setup request message. Consider the case that before mme receives either Activate Default/Dedicated Eps Bearer Context Accept message or E-Rab-Setup Response message, mme may get re-started.
On mme recovery, it identifies that T3485 timer is running, so mme re-transmits the Activate Default/Dedicated Eps Bearer Context Request message. If this message is sent in E-Rab-Setup Request message. On reception of E-Rab-Setup Request message at eNB for same bearer, eNB sends E-Rab-Setup failure with cause as “Multiple E-RAB ID instances” ( This is as per the s1ap spec, 36.413 section 8.2.1.4 ). So eNB will not be able to forward the re-transmitted Activate Default/Dedicated Eps Bearer Context Request message to UE.
So in order to reach esm message to UE, the re-transmitted message needs to be sent DL nas message, so that eNB transparently send the esm message to UE.

Dependent PRs are,
#3968
#5954:
The code is modified to send Activate Default/Dedicated Eps Bearer Context Request message in DL nas message. Accordingly modified the test cases in this PR
magma/S1APTester#54:
In order to expire 3485 timer for default bearer, it requires s1ap code changes and is available in PR,

…bearer Signed-off-by: rashmi <rashmi.sarwad@radisys.com>

…d_testcase_for_3485_timer

ulaskozat · 2021-03-22T18:34:58Z

Is this PR up to date, active? Otherwise let's close it.

ekowtaylor · 2021-03-23T09:54:12Z

@ssanadhya and @rsarwad any plans to move this PR along?

ssanadhya · 2021-03-31T16:30:21Z

@rsarwad , as this PR needs changes on MME logic, created issue #5853 to track this. Closing this PR for now. Please create a new one when the MME logic is implemented.

…for_3485_timer Signed-off-by: rashmi <rashmi.sarwad@radisys.com>

themarwhal · 2021-05-12T15:11:13Z

Hey @rsarwad !
Please see python conventions for instructions on running the linter / formatter locally.

cd magma/lte/gateway/python
./precommit.py --format --diff
./precommit.py --lint --path lte/gateway/python/integ_tests/s1aptests/test_attach_detach_dedicated_activation_timer_expiry.py

…earer requests Signed-off-by: rashmi <rashmi.sarwad@radisys.com>

…for_3485_timer Signed-off-by: rashmi <rashmi.sarwad@radisys.com>

ulaskozat

can you double check the linter comments?

ulaskozat · 2021-05-19T02:20:13Z

...ateway/python/integ_tests/s1aptests/test_3485_timer_for_dedicated_bearer_with_mme_restart.py

+               Request message, so that re-transmitted message reaches to
+               TFW
+        Step5: Send command to Magma to restart mme service
+        Step6: TFW shall receive re-transmitted Actiavte Dedicated EPS


spelling error Actiavte

ulaskozat · 2021-05-19T02:20:26Z

...ateway/python/integ_tests/s1aptests/test_3485_timer_for_dedicated_bearer_with_mme_restart.py

+               TFW
+        Step5: Send command to Magma to restart mme service
+        Step6: TFW shall receive re-transmitted Actiavte Dedicated EPS
+               Bearer Context Request and send Actiavte Dedicated EPS Bearer


same spelling error.

ulaskozat · 2021-05-19T02:22:58Z

...ateway/python/integ_tests/s1aptests/test_3485_timer_for_dedicated_bearer_with_mme_restart.py

+                'IMSI' + ''.join([str(idx) for idx in req.imsi]), 5, 6,
+            )
+            """During wait time, mme may send multiple times Activate EPS bearer
+               context request, after sending response one message ignore other


the sentence does not look correct, did you intend to say after sending response for the first message, ignore the subsequent messages?

Yes
Rephrased the comment

ulaskozat

LGTM

ulaskozat · 2021-05-19T22:34:29Z

...ateway/python/integ_tests/s1aptests/test_3485_timer_for_dedicated_bearer_with_mme_restart.py

+        Step6: TFW shall receive re-transmitted Activate Dedicated EPS
+        Bearer Context Request and send Activate Dedicated EPS Bearer
+        Context Accept
+        Step7: TFW shall initiate de-activation of deidicated bearer and then


typo deidicated

Signed-off-by: rashmi <rashmi.sarwad@radisys.com>

…for_3485_timer Signed-off-by: rashmi <rashmi.sarwad@radisys.com>

themarwhal · 2021-05-20T14:25:10Z

Hey @rsarwad ! Feel free to tag 'ready2merge' if it's ready to be merged.

rsarwad · 2021-05-20T14:41:51Z

The PR is ready2merge

Signed-off-by: rashmi <rashmi.sarwad@radisys.com>

…bearer (magma#3970) Signed-off-by: Ramon Melero <ramonmelero@fb.com>

rsarwad requested review from ssanadhya and ulaskozat as code owners December 9, 2020 15:45

rsarwad mentioned this pull request Dec 9, 2020

Rsarwad handle 3485 timer #3968

Merged

ardzoht linked an issue Dec 9, 2020 that may be closed by this pull request

Handling timer 3485 and 3495 in stateless MME #3883

Closed

rsarwad added 2 commits December 10, 2020 05:14

Added testcase to validate 3485 timer for both default and dedicated …

b210c8e

…bearer Signed-off-by: rashmi <rashmi.sarwad@radisys.com>

Merge branch 'master' of https://github.com/rsarwad/magma into rsarwa…

3de91cf

…d_testcase_for_3485_timer

ssanadhya removed a link to an issue Dec 15, 2020

Handling timer 3485 and 3495 in stateless MME #3883

Closed

magmabot added component: agw Access gateway-related issue component: cwag CWAG related issues labels Jan 5, 2021

ssanadhya mentioned this pull request Mar 31, 2021

[agw][mme] Retransmit Activate Default/Dedicated Eps Bearer Context Request in DL NAS message #5853

Closed

ssanadhya closed this Mar 31, 2021

Merge remote-tracking branch 'upstream/master' into rsarwad_testcase_…

2a3580f

…for_3485_timer Signed-off-by: rashmi <rashmi.sarwad@radisys.com>

rsarwad reopened this May 12, 2021

pull-request-size bot added the size/XL Denotes a Pull Request that changes 500-999 lines. label May 12, 2021

themarwhal requested review from a team and removed request for ssanadhya May 12, 2021 15:08

rsarwad force-pushed the rsarwad_testcase_for_3485_timer branch from 1f8d678 to 2a3580f Compare May 12, 2021 18:07

pull-request-size bot added size/L Denotes a Pull Request that changes 100-499 lines. and removed size/XL Denotes a Pull Request that changes 500-999 lines. labels May 12, 2021

rsarwad mentioned this pull request May 12, 2021

Added code to send Activate Default/Dedicated Bearer Request in DL nas message #5954

Merged

rsarwad force-pushed the rsarwad_testcase_for_3485_timer branch from db4aa20 to b4b6b74 Compare May 14, 2021 03:43

rsarwad added 2 commits May 14, 2021 17:14

Modified script to address re-trasmitted activate default/dedicated b…

b4b6b74

…earer requests Signed-off-by: rashmi <rashmi.sarwad@radisys.com>

Merge remote-tracking branch 'upstream/master' into rsarwad_testcase_…

91b4752

…for_3485_timer Signed-off-by: rashmi <rashmi.sarwad@radisys.com>

ulaskozat reviewed May 19, 2021

View reviewed changes

rsarwad mentioned this pull request May 19, 2021

Added code to drop activate default bearer context request magma/S1APTester#54

Merged

rsarwad force-pushed the rsarwad_testcase_for_3485_timer branch 10 times, most recently from f84d41a to ca63a99 Compare May 19, 2021 18:37

ulaskozat approved these changes May 19, 2021

View reviewed changes

ulaskozat reviewed May 19, 2021

View reviewed changes

rsarwad added 2 commits May 20, 2021 08:09

Incorporated review comments

ca63a99

Signed-off-by: rashmi <rashmi.sarwad@radisys.com>

Merge remote-tracking branch 'upstream/master' into rsarwad_testcase_…

86ed199

…for_3485_timer Signed-off-by: rashmi <rashmi.sarwad@radisys.com>

themarwhal added the ready2merge This PR is ready to be merged (is approved and passes all required checks) label May 20, 2021

themarwhal merged commit 2c8219b into magma:master May 20, 2021

Incorporated review comments

3533f45

Signed-off-by: rashmi <rashmi.sarwad@radisys.com>

rmeleromira pushed a commit to rmeleromira/magma that referenced this pull request Jul 24, 2021

Added testcase to validate 3485 timer for both default and dedicated …

9e2e500

…bearer (magma#3970) Signed-off-by: Ramon Melero <ramonmelero@fb.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added testcase to validate 3485 timer for both default and dedicated bearer #3970

Added testcase to validate 3485 timer for both default and dedicated bearer #3970

rsarwad commented Dec 9, 2020 •

edited

ulaskozat commented Mar 22, 2021

ekowtaylor commented Mar 23, 2021

ssanadhya commented Mar 31, 2021

themarwhal commented May 12, 2021 •

edited

ulaskozat left a comment

ulaskozat May 19, 2021

ulaskozat May 19, 2021

ulaskozat May 19, 2021

rsarwad May 19, 2021 •

edited

ulaskozat left a comment

ulaskozat May 19, 2021

themarwhal commented May 20, 2021

rsarwad commented May 20, 2021

Added testcase to validate 3485 timer for both default and dedicated bearer #3970

Added testcase to validate 3485 timer for both default and dedicated bearer #3970

Conversation

rsarwad commented Dec 9, 2020 • edited

Summary

Test Plan

ulaskozat commented Mar 22, 2021

ekowtaylor commented Mar 23, 2021

ssanadhya commented Mar 31, 2021

themarwhal commented May 12, 2021 • edited

ulaskozat left a comment

Choose a reason for hiding this comment

ulaskozat May 19, 2021

Choose a reason for hiding this comment

ulaskozat May 19, 2021

Choose a reason for hiding this comment

ulaskozat May 19, 2021

Choose a reason for hiding this comment

rsarwad May 19, 2021 • edited

Choose a reason for hiding this comment

ulaskozat left a comment

Choose a reason for hiding this comment

ulaskozat May 19, 2021

Choose a reason for hiding this comment

themarwhal commented May 20, 2021

rsarwad commented May 20, 2021

rsarwad commented Dec 9, 2020 •

edited

themarwhal commented May 12, 2021 •

edited

rsarwad May 19, 2021 •

edited