New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[lte][agw]Bug fix for missing ue context at spgw #4141
Merged
ulaskozat
merged 2 commits into
magma:master
from
pruthvihebbani:bug_fix_missing_ue_context_spgw
Dec 21, 2020
Merged
[lte][agw]Bug fix for missing ue context at spgw #4141
ulaskozat
merged 2 commits into
magma:master
from
pruthvihebbani:bug_fix_missing_ue_context_spgw
Dec 21, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pruthvi Hebbani <pruthvi.hebbani@radisys.com>
Signed-off-by: Pruthvi Hebbani <pruthvi.hebbani@radisys.com>
ulaskozat
approved these changes
Dec 21, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
this seems to have fixed this issue |
ssanadhya
pushed a commit
that referenced
this pull request
Jan 8, 2021
* Bug fix for missing ue context at spgw Signed-off-by: Pruthvi Hebbani <pruthvi.hebbani@radisys.com>
1 task
pshelar
added a commit
to pshelar/magma
that referenced
this pull request
Jan 9, 2021
This reverts commit d356a00.
pshelar
added a commit
to pshelar/magma
that referenced
this pull request
Jan 9, 2021
This reverts commit d356a00. Signed-off-by: Pravin B Shelar <pbshelar@fb.com>
ssanadhya
pushed a commit
that referenced
this pull request
Jan 9, 2021
This was referenced Jan 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
apply-v1.3
Needs to be applied to v1.3 release branch as well
backported-v1.3
Has been backported to v1.3 release branch
component: agw
Access gateway-related issue
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Pruthvi Hebbani pruthvi.hebbani@radisys.com
[lte][agw]Bug fix for missing ue context at spgw
Summary
Issue description:
a. There are 2 UEs which are in the process of attach say UE1 and UE2. UE1 has sent out initial context setup request message and waiting for response. UE2 has performed GUTI attach. As part of GUTI attach, identification procedure is done and MME has sent out authentication request message to UE and waiting for authentication response.
b. ICS timer expires for UE1 and implicit detach is triggered. MME sends delete session request message to spgw and the UE context at spgw gets deleted. In the mean time ICS response message is received from UE1. At mme, there is no check to see that the ICS timer has already expired and implicit detach has been triggered for this UE. Due to this mme sends modify bearer request message to spgw. Before spgw triggers delete session rsp message to mme (in response to delete session req sent by mme) it receives modify bearer request message. As the ue context at spgw is deleted, spgw sends modify bearer rsp with cause “CONTEXT NOT FOUND”. But this message does not contain mme s11 teid. Mme s11 teid is included only in the successful case.
c. Mme receives modify bearer rsp message with mme s11 teid value 0 and fetches the context of UE2 instead of UE1. This is because when mme performs identification procedure for UE2 it inserts mme s11 teid into the hashtable even though the value of mme s11 teid is 0. Mme s11 teid gets allocated during create session procedure which is not yet done for UE2
d. Mme triggers bearer deactivation procedure for UE2 (instead of UE1) as the context at spgw is not available
e. Since authentication procedure is not yet completed for UE2, security context is not yet available for this UE. When mme tries to build erab release command message it crashes as there is no null check on the security context. This fix is done PR #4067
This PR has the following fixes:
Test Plan