Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pipelined]Fix NIL Delete in QOS Restart Recovery #4186

Merged
merged 1 commit into from Dec 28, 2020
Merged

[pipelined]Fix NIL Delete in QOS Restart Recovery #4186

merged 1 commit into from Dec 28, 2020

Conversation

koolzz
Copy link
Contributor

@koolzz koolzz commented Dec 28, 2020

Signed-off-by: Nick Yurchenko koolzz@fb.com

Summary

Test Plan

Additional Information

  • This change is backwards-breaking

@koolzz
Fix nil delete in qos
3adb0ce 
Signed-off-by: Nick Yurchenko <koolzz@fb.com>
@koolzz koolzz requested a review from pshelar as a code owner December 28, 2020 19:43
@koolzz koolzz linked an issue Dec 28, 2020 that may be closed by this pull request
Qos Redis Issue #4170
Closed
@magmabot magmabot added component: agw Access gateway-related issue component: cwag CWAG related issues labels Dec 28, 2020
pshelar
pshelar approved these changes Dec 28, 2020
View reviewed changes
Copy link
Contributor

@pshelar pshelar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@koolzz koolzz merged commit 028339f into magma:master Dec 28, 2020
pshelar pushed a commit to pshelar/magma that referenced this pull request Jan 12, 2021
@koolzz @pshelar
[pipelined]Fix NIL Delete in QOS Restart Recovery (magma#4186)
b9eb60b 
Signed-off-by: Nick Yurchenko <koolzz@fb.com>
@pshelar pshelar mentioned this pull request Jan 12, 2021
Merged
1 task
ssanadhya pushed a commit that referenced this pull request Jan 12, 2021
@pshelar @koolzz
[pipelined]Fix NIL Delete in QOS Restart Recovery (#4186) (#4337)
e5ba0db 
Signed-off-by: Nick Yurchenko <koolzz@fb.com>

Co-authored-by: Mykola Yurchenko <koolzz@fb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pshelar pshelar pshelar approved these changes

Assignees
No one assigned
Labels
component: agw Access gateway-related issue component: cwag CWAG related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Qos Redis Issue
3 participants
@koolzz @pshelar @magmabot