[agw][mme] Make ctime call thread safe #4216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shruti Sanadhya <ssanadhya@fb.com>
ssanadhya
added
component: agw
pshelar
approved these changes
Dec 31, 2020
| @@ -563,7 +563,8 @@ static char* log_get_readable_cur_time(time_t* cur_time) { | |||
| // get the current local time | |||
| *cur_time = time(NULL); | |||
| // get the current local time in readable string format | |||
| return (strtok(ctime(cur_time), "\n")); | |||
| char buf[26]; | |||
There was a problem hiding this comment.
This is exact buf required, I would gone with larger buffer than required.
There was a problem hiding this comment.
@pshelar missed this comment before merging this PR. Could you please suggest an alternative size for the buffer? I can fix it in a separate PR.
tmdzk
pushed a commit
that referenced
this pull request
Jan 1, 2021
Signed-off-by: Shruti Sanadhya <ssanadhya@fb.com>
|
backported |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shruti Sanadhya ssanadhya@fb.com
Summary
MME service encountered seg faults due to memory corruption while calling ctime. This change replaces
ctimewithctime_rTest Plan
make integ_test