Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lte][agw] Remove paging timer when ue context is removed #4302

Merged
merged 2 commits into from Jan 8, 2021

Conversation

ulaskozat
Copy link
Contributor

Signed-off-by: Ulas Kozat kozat@fb.com

Summary

When UE context is removed, all the timers should be removed as well. The paging response timer was missing and this PR adds it to context cleanup.

Test Plan

S1AP tests for sanity.
Fuzz testing.

Additional Information

  • This change is backwards-breaking

Signed-off-by: Ulas Kozat <kozat@fb.com>
@ulaskozat ulaskozat added component: agw Access gateway-related issue apply-v1.3 Needs to be applied to v1.3 release branch as well labels Jan 8, 2021
@magmabot magmabot added the component: cwag CWAG related issues label Jan 8, 2021
Copy link
Collaborator

@ssanadhya ssanadhya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Side BE cleanup, can we get rid of line 311 here as it is redundant.

Signed-off-by: Ulas Kozat <kozat@fb.com>
@ulaskozat ulaskozat merged commit ab61537 into magma:master Jan 8, 2021
ulaskozat added a commit to ulaskozat/magma that referenced this pull request Jan 9, 2021
* Remove paging timer when ue context is removed

Signed-off-by: Ulas Kozat <kozat@fb.com>
ulaskozat added a commit that referenced this pull request Jan 9, 2021
)

* Remove paging timer when ue context is removed

Signed-off-by: Ulas Kozat <kozat@fb.com>
@ulaskozat ulaskozat added the backported-v1.3 Has been backported to v1.3 release branch label Jan 9, 2021
ulaskozat added a commit to ulaskozat/magma that referenced this pull request Jan 9, 2021
* Remove paging timer when ue context is removed

Signed-off-by: Ulas Kozat <kozat@fb.com>
ulaskozat added a commit that referenced this pull request Jan 9, 2021
)

* Remove paging timer when ue context is removed

Signed-off-by: Ulas Kozat <kozat@fb.com>
ulaskozat added a commit to ulaskozat/magma that referenced this pull request Jan 10, 2021
* Remove paging timer when ue context is removed

Signed-off-by: Ulas Kozat <kozat@fb.com>
ulaskozat added a commit that referenced this pull request Jan 10, 2021
)

* Remove paging timer when ue context is removed

Signed-off-by: Ulas Kozat <kozat@fb.com>
ssanadhya pushed a commit to ssanadhya/magma that referenced this pull request Jan 21, 2021
* Remove paging timer when ue context is removed

Signed-off-by: Ulas Kozat <kozat@fb.com>
pshelar added a commit to pshelar/magma that referenced this pull request Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apply-v1.3 Needs to be applied to v1.3 release branch as well backported-v1.3 Has been backported to v1.3 release branch component: agw Access gateway-related issue component: cwag CWAG related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants