New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[lte][agw] Remove paging timer when ue context is removed #4302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ulas Kozat <kozat@fb.com>
ulaskozat
added
component: agw
Access gateway-related issue
apply-v1.3
Needs to be applied to v1.3 release branch as well
labels
Jan 8, 2021
ssanadhya
approved these changes
Jan 8, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Side BE cleanup, can we get rid of line 311 here as it is redundant.
Signed-off-by: Ulas Kozat <kozat@fb.com>
ulaskozat
added a commit
to ulaskozat/magma
that referenced
this pull request
Jan 9, 2021
* Remove paging timer when ue context is removed Signed-off-by: Ulas Kozat <kozat@fb.com>
ulaskozat
added a commit
to ulaskozat/magma
that referenced
this pull request
Jan 9, 2021
* Remove paging timer when ue context is removed Signed-off-by: Ulas Kozat <kozat@fb.com>
ulaskozat
added a commit
to ulaskozat/magma
that referenced
this pull request
Jan 10, 2021
* Remove paging timer when ue context is removed Signed-off-by: Ulas Kozat <kozat@fb.com>
ssanadhya
pushed a commit
to ssanadhya/magma
that referenced
this pull request
Jan 21, 2021
* Remove paging timer when ue context is removed Signed-off-by: Ulas Kozat <kozat@fb.com>
pshelar
added a commit
to pshelar/magma
that referenced
this pull request
Jan 29, 2021
…gma#4302) (magma#4312)" This reverts commit f1be5d6.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
apply-v1.3
Needs to be applied to v1.3 release branch as well
backported-v1.3
Has been backported to v1.3 release branch
component: agw
Access gateway-related issue
component: cwag
CWAG related issues
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ulas Kozat kozat@fb.com
Summary
When UE context is removed, all the timers should be removed as well. The paging response timer was missing and this PR adds it to context cleanup.
Test Plan
S1AP tests for sanity.
Fuzz testing.
Additional Information