Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lte][agw] Support to test pco option ipcp #4767

Merged
merged 7 commits into from May 5, 2021

Conversation

pruthvihebbani
Copy link
Contributor

@pruthvihebbani pruthvihebbani commented Feb 4, 2021

[lte][agw] Support to test pco option ipcp

Summary

  • Added support in s1ap utility to include pco option ipcp
  • Added a new s1 sim testcase to test ipcp
  • Minor change in the debug log

Test Plan

Tested that s1sim includes ipcp option in PCO IE in pdn connectivity request message during attach procedure and MME sends primary and secondary dns ip addresses in the PCO IE in activate default eps bearer context message

@magmabot magmabot added component: agw Access gateway-related issue component: cwag CWAG related issues labels Feb 4, 2021
@rdefosse
Copy link
Contributor

rdefosse commented Feb 4, 2021

MAGMA-OAI-TESTS

Signed-off-by: Pruthvi Hebbani <pruthvi.hebbani@radisys.com>
Signed-off-by: Pruthvi Hebbani <pruthvi.hebbani@radisys.com>
@rdefosse
Copy link
Contributor

rdefosse commented Feb 8, 2021

MAGMA-OAI-TESTS

Signed-off-by: Pruthvi Hebbani <pruthvi.hebbani@radisys.com>
@ulaskozat
Copy link
Contributor

ulaskozat commented Mar 22, 2021

@pruthvihebbani is this still work in progress or something ready to be reviewed?
@ulaskozat its WIP because after adding support in s1ap utils to send ipcp option in pco, I could not reproduce the issue you were facing. The TC I have added works fine. So I wanted to crosscheck the pcap and logs of the issue you are facing to see if they match with my changes. I had asked you to share the issue logs.

Copy link
Contributor

@ulaskozat ulaskozat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ulaskozat ulaskozat changed the title {WIP}[lte][agw] Support to test pco option ipcp [lte][agw] Support to test pco option ipcp Mar 23, 2021
@ulaskozat
Copy link
Contributor

@pruthvihebbani I removed {WIP} from the title and let's land this.

@pull-request-size pull-request-size bot added the size/L Denotes a Pull Request that changes 100-499 lines. label Mar 25, 2021
Signed-off-by: Pruthvi Hebbani <pruthvi.hebbani@radisys.com>
@themarwhal themarwhal requested a review from a team May 4, 2021 15:07
@ekowtaylor
Copy link
Contributor

@ulaskozat looks like this is ready to me merged and closed, can we move it along?

@ulaskozat ulaskozat merged commit 0703ad4 into magma:master May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: agw Access gateway-related issue component: cwag CWAG related issues size/L Denotes a Pull Request that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants