Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feg] s8_proxy fix TEIDs on Create Session and add DeleteSession to s8_cli and made s8 stateless #5011

Merged
merged 5 commits into from Mar 5, 2021
Merged

[feg] s8_proxy fix TEIDs on Create Session and add DeleteSession to s8_cli and made s8 stateless #5011

merged 5 commits into from Mar 5, 2021

Conversation

uri200
Copy link
Contributor

@uri200 uri200 commented Feb 18, 2021 •
edited

Signed-off-by: Oriol Batalla obatalla@fb.com

Summary

This PR includes changes to the original s8_proxy and some new additions:

  • Fix an issue where FTEIDs were displaying with no IP
  • Changed the way the server finds out its own ip and uses it to send it as a parameter on the GTP-C create session message.
  • Changed tests to add more checks, specially on teids. Added a way to see what TEIDs were assigned by the MockPgw
  • Improved functions in sender.go to display better logs in debugging mode
  • Added DeleteSession and EchoRequest to tools/s8_cli
  • Improved proto definiton
  • Disabled validation in go-gtp (triggered a refactor on how we handle IE to proto conversion)
  • Added multithread test with multiple users creating and deleting sessions at the same time
  • Final commit includes a major refactor to remove state from s8_proxy and rely on mme to store state (mainly teids being used). S8_proxy now can be restarted and sessions will not be affected

Test Plan

./build -g && ./build --test at orc8r
make precommit at feg
Test on teravm and HCore with s8_cli

Additional Information

  • This change is backwards-breaking

@uri200 uri200 changed the title [directoryd][mobilityd] Add grpc messages to log [feg] s8 fix teids Feb 18, 2021
@uri200 uri200 marked this pull request as ready for review February 19, 2021 19:30
@uri200 uri200 added the component: feg FEG-gateway related issues label Feb 19, 2021
@uri200 uri200 changed the title [feg] s8 fix teids [feg] s8_proxy fix TEIDs on Create Session and add DeleteSession to s8_cli Feb 19, 2021
@uri200 uri200 linked an issue Feb 19, 2021 that may be closed by this pull request
[Inbound Roaming][FEG] Create s8_proxy #3595
Closed
@uri200 uri200 mentioned this pull request Feb 19, 2021
Closed
@uri200 uri200 force-pushed the feg_s8_fix_teids branch 2 times, most recently from 15fe219 to f312f86 Compare February 22, 2021 22:01
@uri200 uri200 marked this pull request as draft February 23, 2021 07:47
@uri200 uri200 marked this pull request as ready for review February 25, 2021 22:13
@uri200 uri200 marked this pull request as draft March 1, 2021 06:05
@uri200 uri200 marked this pull request as ready for review March 1, 2021 21:38
uri200
uri200 commented Mar 1, 2021
View reviewed changes
feg/gateway/gtp/gtp_client.go
time.Sleep(time.Millisecond * 20)
time.Sleep(time.Millisecond * 20)
time.Sleep(time.Millisecond * 20)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is going to stay here for now. Otherwise test may fail on ci

There is a PR on go-gtp already approved to fix this issue. Still waiting for the new tag to apply the new version to our s8_proxy

@uri200 uri200 changed the title [feg] s8_proxy fix TEIDs on Create Session and add DeleteSession to s8_cli [feg] s8_proxy fix TEIDs on Create Session and add DeleteSession to s8_cli and made s8 stateless Mar 2, 2021
@uri200
[feg] Fix Teid on Create Session and unbound local clientIP from Swg …
6a5054b 
…ip address

Signed-off-by: Oriol Batalla <obatalla@fb.com>
@uri200
[feg] S8 modify how we get local address
15c3a48 
Signed-off-by: Oriol Batalla <obatalla@fb.com>
@uri200
[feg] S8_proxy additon of delete session
eb5afe5 
Signed-off-by: Oriol Batalla <obatalla@fb.com>
@uri200
[feg] S8 disabled validation on go-gtp
2317713 
Signed-off-by: Oriol Batalla <obatalla@fb.com>
@uri200
[feg] s8_proxy major refactor to remove state from s8
43e1b1f 
Signed-off-by: Oriol Batalla <obatalla@fb.com>
@uri200 uri200 enabled auto-merge (squash) March 5, 2021 04:26
@uri200 uri200 merged commit 5243a71 into magma:master Mar 5, 2021
@uri200 uri200 deleted the feg_s8_fix_teids branch March 27, 2021 04:39
chandra-77 pushed a commit to chandra-77/magma that referenced this pull request Mar 30, 2021
@uri200 @chandra-77
[feg] s8_proxy fix TEIDs on Create Session and add DeleteSession to s…
aac2826 
…8_cli and made s8 stateless (magma#5011)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@themarwhal themarwhal themarwhal approved these changes

@emakeev emakeev Awaiting requested review from emakeev

@mpgermano mpgermano Awaiting requested review from mpgermano

Assignees
No one assigned
Labels
component: feg FEG-gateway related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Inbound Roaming][FEG] Create s8_proxy
2 participants
@uri200 @themarwhal