Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Update minikube docs #5233

Merged
merged 1 commit into from
Mar 4, 2021
Merged

[docs] Update minikube docs #5233

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/readmes/orc8r/development/minikube_deployment.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ $ cp -r ../../../../.cache/test_certs/* charts/secrets/.secrets/certs/.
Create the kubernetes secrets

```
helm template orc8r-secrets charts/secrets \
helm template orc8r charts/secrets \
Copy link
Contributor

@ShubhamTatvamasi ShubhamTatvamasi Mar 2, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can conflict with the Orchestrator helm deployment having the same name: helm install orc8r

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think helm template is not creating the helm release, then it's okay.

--namespace magma \
--set-string secret.certs.enabled=true \
--set-file secret.certs.files."rootCA\.pem"=charts/secrets/.secrets/certs/rootCA.pem \
Expand Down
16 changes: 8 additions & 8 deletions orc8r/cloud/helm/orc8r/examples/minikube_values.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,13 @@
# Make sure to replace <DOCKER_REGISTRY> and <TAG> with your specific values.

imagePullSecrets:
- name: orc8r-secrets-secrets-registry
- name: orc8r-secrets-registry

secret:
configs:
orc8r: orc8r-secrets-secrets-configs-orc8r
envdir: orc8r-secrets-secrets-envdir
certs: orc8r-secrets-secrets-certs
orc8r: orc8r-secrets-configs-orc8r
envdir: orc8r-secrets-envdir
certs: orc8r-secrets-certs

controller:
tolerations: []
Expand Down Expand Up @@ -36,9 +36,9 @@ controller:
## NMS
nms:
secret:
certs: orc8r-secrets-secrets-certs
certs: orc8r-secrets-certs
imagePullSecrets:
- name: orc8r-secrets-secrets-registry
- name: orc8r-secrets-registry
pod:
replicas:
nginx:
Expand Down Expand Up @@ -84,7 +84,7 @@ nms:
metrics:
enabled: true
imagePullSecrets:
- name: orc8r-secrets-secrets-registry
- name: orc8r-secrets-registry

metrics:
volumes:
Expand Down Expand Up @@ -125,7 +125,7 @@ logging:
enabled: false
nginx:
secret:
certs: orc8r-secrets-secrets-certs
certs: orc8r-secrets-certs
create: true
replicas: 1
podDisruptionBudget:
Expand Down