Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cloud] [orc8r] [agw] Adding cleanup capabilities for Cloudstrapper #5593

Merged
merged 1 commit into from Mar 29, 2021
Merged

[cloud] [orc8r] [agw] Adding cleanup capabilities for Cloudstrapper #5593

merged 1 commit into from Mar 29, 2021

Conversation

arunuke
Copy link
Contributor

@arunuke arunuke commented Mar 18, 2021

Signed-off-by: Arun Thulasi arunt@fb.com

Summary

Orchestrator cleanup done via 'terraform destroy' might leave out some resources. This impedes future orchestrator re-deployments until these resources are manually cleaned up. The cleanup capability added to Cloudstrapper provides an automatic, customized way to cleanup an orchestrator deployment with or without an associated 'terraform destroy'.

Test Plan

A running orchestrator deployment was cleaned up by following the instructions available from the README file.

Additional Information

The cleanup capability can be used with a Cloudstrapper deployed Orchestrator and with traditionally deployed Orchestrators.

@arunuke arunuke self-assigned this Mar 18, 2021
@arunuke arunuke added the v1.5 label Mar 18, 2021
@codecov
Copy link

codecov bot commented Mar 18, 2021

Codecov Report

Merging #5593 (a9046ba) into master (e82ce14) will not change coverage.
The diff coverage is n/a.

❗ Current head a9046ba differs from pull request most recent head db4fd2d. Consider uploading reports for the commit db4fd2d to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5593   +/-   ##
=======================================
  Coverage   63.49%   63.49%           
=======================================
  Files         302      302           
  Lines       20483    20483           
=======================================
  Hits        13006    13006           
  Misses       5560     5560           
  Partials     1917     1917           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e82ce14...db4fd2d. Read the comment docs.

Copy link
Contributor

@karthiksubraveti karthiksubraveti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most changes look good. Left a few comments. Also I like variables with underscores more than camelcasing here. But if this is the convention you have followed in other places in cloudstrapper, its fine. Thanks for adding this cleanup playbook :). Such a pain to identify and delete all resources manually.

Signed-off-by: Arun Thulasi <arunt@fb.com>
@pull-request-size pull-request-size bot added the size/XL Denotes a Pull Request that changes 500-999 lines. label Mar 29, 2021
@karthiksubraveti karthiksubraveti enabled auto-merge (squash) March 29, 2021 17:48
@karthiksubraveti karthiksubraveti merged commit cebc5dd into magma:master Mar 29, 2021
@arunuke arunuke deleted the orc8r-aws-cleanup branch March 29, 2021 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XL Denotes a Pull Request that changes 500-999 lines. v1.5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants