Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for band 39 to orc8r #612

Closed
wants to merge 1 commit into from
Closed

Adding support for band 39 to orc8r #612

wants to merge 1 commit into from

Conversation

m0ch1m0ch1
Copy link
Contributor

Summary:
Band39 is already supported by issue #481 and PR #482 .
However, this patch (#481 , #482 ) was only support A-GW and Orc8r was not supported.
This PR adds band39 support to orc8r by adding the network cellular config on orc8r.

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Copy link
Contributor

@xjtian xjtian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks legit, thanks!

http://niviuk.free.fr/lte_band.php

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xjtian has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@xjtian merged this pull request in fe0f297.

@m0ch1m0ch1 m0ch1m0ch1 deleted the add_support_band39_to_orc8r branch October 24, 2019 07:07
facebook-github-bot pushed a commit that referenced this pull request May 12, 2020
Summary:
Pull Request resolved: https://github.com/facebookincubator/symphony/pull/612

add policy for equipment position definition

Reviewed By: naor9991

Differential Revision: D21503751

fbshipit-source-id: 1391e6840bb609b11e8a4f0be288494d241f3025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants